Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making Ftp/computePath method protected #415

Open
anvaya opened this issue May 30, 2016 · 0 comments
Open

Consider making Ftp/computePath method protected #415

anvaya opened this issue May 30, 2016 · 0 comments
Assignees

Comments

@anvaya
Copy link

anvaya commented May 30, 2016

For the adapter classes, the access control varies by the adapter. The Local adapter as computePath method as protected, while the Ftp adapter class has computePath private.

This has made it impossible to override methods such as Read without modifying the access of base Ftp adapter methods to protected to be able to call methods such as computePath.

I implemented custom read method for the FTP adapter to stream the file directly to the browser without first downloading it on the server, ended up modifying the base ftp class methods to protected.

@fabschurt fabschurt self-assigned this Apr 12, 2017
@fabschurt fabschurt removed their assignment Oct 16, 2019
@PedroTroller PedroTroller self-assigned this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants