Dropbox Adapter Factory added #67

Merged
merged 4 commits into from Nov 4, 2013

Projects

None yet

4 participants

@radutopala
Contributor

No description provided.

@l3l0
Collaborator
l3l0 commented Oct 4, 2013

@radutopala Nice thanks :) Could you add some usage documenation into README ?

@radutopala
Contributor

@l3l0 sure thing, I'll do that.

@radutopala
Contributor

@l3l0 Documentation added.

@radutopala radutopala referenced this pull request in KnpLabs/Gaufrette Oct 5, 2013
Closed

Dropbox API changes #214

@radutopala
Contributor

Related to KnpLabs/Gaufrette#214.

@stof stof commented on an outdated diff Oct 5, 2013
DependencyInjection/Factory/DropboxAdapterFactory.php
+ /**
+ * {@inheritDoc}
+ */
+ function getKey()
+ {
+ return 'dropbox';
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ function addConfiguration(NodeDefinition $builder)
+ {
+ $builder
+ ->children()
+ ->scalarNode('api_id')->isRequired()->end()
@stof
stof Oct 5, 2013 Contributor

you should add ->cannotBeEmpty()

@radutopala
Contributor

@stof pls check again.

@kcivey
kcivey commented Nov 1, 2013

Anything happening with this?

@radutopala
Contributor

@kcivey I plan to create a full example of gaufrette with dropbox, because my PRs seems like are not getting through for some reason :)

@kcivey
kcivey commented Nov 1, 2013

Thanks, @radutopala. I'm installing your fork now.

@l3l0 l3l0 merged commit 9e70925 into KnpLabs:master Nov 4, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment