Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 compatibility #332

Merged
merged 19 commits into from
Jul 31, 2020
Merged

PHP 8 compatibility #332

merged 19 commits into from
Jul 31, 2020

Conversation

Glancu
Copy link
Contributor

@Glancu Glancu commented Jul 15, 2020

No description provided.

@garak garak self-requested a review July 15, 2020 11:41
Copy link
Collaborator

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get passing tests on php 8 in order to require it.
So, you we should remove "nightly" from "allow_failures" in travis configuration.

@garak
Copy link
Collaborator

garak commented Jul 15, 2020

As you can see in travis logs, this is currently not working.
We need 2 additional steps:

  1. prophecy php 8 support (see related issue)
  2. allowing latest prophecy version (only after point 1 is solved)

@derrabus
Copy link
Contributor

As you can see in travis logs, this is currently not working.

If you want to to wait for external projects to adjust their php constraints, you could temporarily add the following line to the nightly run:

composer config platform.php 7.4.99

This is how Symfony currently runs the tests on php 8.

@Glancu
Copy link
Contributor Author

Glancu commented Jul 15, 2020

As you can see in travis logs, this is currently not working.

If you want to to wait for external projects to adjust their php constraints, you could temporarily add the following line to the nightly run:

composer config platform.php 7.4.99

This is how Symfony currently runs the tests on php 8.

I added commit with script platform, but changes in PR not detected. Do you know why?
https://github.com/Glancu/KnpMenu/commit/23025d3fbf6582790281c2c47a8d3867f1dff0c1

composer.json Outdated Show resolved Hide resolved
@derrabus
Copy link
Contributor

derrabus commented Jul 15, 2020

The php 8 build is deep red now because PHPUnit 8.3 (installed by PhpUnitBridge) is incompatible with php 8. Symfony is struggling with the same issue at the moment, see symfony/symfony#37564.

We might be able to fix this by dropping PhpUnitBridge and install PHPUnit 9.3-dev for the nightly run. 🤔

composer.json Outdated Show resolved Hide resolved
@stof
Copy link
Collaborator

stof commented Jul 16, 2020

We might be able to fix this by dropping PhpUnitBridge and install PHPUnit 9.3-dev for the nightly run.

Or forcing the PHPUnit version installed by the bridge in the PHP 8 job for now.

@derrabus
Copy link
Contributor

Or forcing the PHPUnit version installed by the bridge in the PHP 8 job for now.

PHPUnit 9.3 breaks the bridge atm, I'm afraid.

@garak garak merged commit fe1b2f5 into KnpLabs:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants