-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8 compatibility #332
PHP 8 compatibility #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to get passing tests on php 8 in order to require it.
So, you we should remove "nightly" from "allow_failures" in travis configuration.
As you can see in travis logs, this is currently not working.
|
If you want to to wait for external projects to adjust their php constraints, you could temporarily add the following line to the
This is how Symfony currently runs the tests on php 8. |
I added commit with script platform, but changes in PR not detected. Do you know why? |
The php 8 build is deep red now because PHPUnit 8.3 (installed by PhpUnitBridge) is incompatible with php 8. Symfony is struggling with the same issue at the moment, see symfony/symfony#37564. We might be able to fix this by dropping PhpUnitBridge and install PHPUnit 9.3-dev for the nightly run. 🤔 |
Or forcing the PHPUnit version installed by the bridge in the PHP 8 job for now. |
PHPUnit 9.3 breaks the bridge atm, I'm afraid. |
No description provided.