Updated the bundle's installation instructions #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javiereguiluz what do you think about completely removing the deps installations and other outdated details like sub modules? This is what I prefer and have done it on a few bundles :) Thanks! |
|
@weaverryan I prefer that too but I didn't want to be too radical :) |
|
Please be radical. The deps file and submodules instructions should both be removed in favor of using Composer |
|
👍 It reads well to me! |
stof
added a commit
that referenced
this pull request
Dec 4, 2014
Updated the bundle's installation instructions
|
thanks |
EmmanuelVella
pushed a commit
to EmmanuelVella/KnpMenuBundle
that referenced
this pull request
Sep 23, 2020
Refactor testing (improv. cc and reduce execution time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Symfony Community is trying to update the installation instructions for all bundles and we've started with the major ones, such as KnpMenuBundle. That's why I propose to update the instructions to use the latest Composer features and to clearly show that Symfony 2.0 stuff is really legacy.