feat: drop support for php 8.0 #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that KnpMenu still support PHP 8.0, I find it weird to drop it in the bundle (especially with a changelog entry saying it is done to match) |
migrate phpunit.xml.dist to version 10 allow PHPUnit 11
Chris53897
force-pushed
the
feature/drop-support-for-php-8
branch
from
b0c92bd
to
8a5b902
Compare
garak
approved these changes
Mar 10, 2024
derrabus
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate phpunit.xml.dist to version 10
allow PHPUnit 11
The change to Attributes, is to fix the deprecation warnings from PHPUnit 11
Maybe it is already time to drop support for php 8.0
#460 (comment)