Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bulma pagination template for version 0.6.x #473

Merged
merged 7 commits into from Mar 6, 2018

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Feb 19, 2018

Hey,

This PR update Bulma pagination template for version 0.6.x because it's broken (#399 was probably created during the version 0.2 of Bulma)

This is what the current template renders:

capture d ecran de 2018-02-19 22-04-55

And this is what my patch renders:

Small pagination:
capture d ecran de 2018-02-19 22-26-57
capture d ecran de 2018-02-19 22-27-05

Big pagination:
capture d ecran de 2018-02-19 22-25-46
capture d ecran de 2018-02-19 22-25-54
capture d ecran de 2018-02-19 22-26-07
capture d ecran de 2018-02-19 22-26-17

And also, I made the Bulma render customizable (doc). You can customize the position, the size, and make buttons rounded or not.

Thanks

@Kocal Kocal changed the title Update Bulma pagination template for version 0.6.x [WIP] Update Bulma pagination template for version 0.6.x Feb 20, 2018
@Kocal Kocal changed the title [WIP] Update Bulma pagination template for version 0.6.x Update Bulma pagination template for version 0.6.x Feb 20, 2018
@Kocal Kocal force-pushed the feature/update-bulma-pagination-template branch from b5ba5a5 to 476d009 Compare February 20, 2018 06:26
@Kocal Kocal force-pushed the feature/update-bulma-pagination-template branch from 9b98bcd to 36f46d0 Compare February 22, 2018 06:07
@polc polc merged commit 8823617 into KnpLabs:master Mar 6, 2018
@polc
Copy link
Contributor

polc commented Mar 6, 2018

LGTM, thanks a lot @Kocal !

@Kocal Kocal deleted the feature/update-bulma-pagination-template branch November 29, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants