Set new parameters as null instead of default values

KnpLabs · Apr 20, 2020 · 041af92 · 041af92
1 parent 6aa74fb
commit 041af92
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/lib/Github/Api/Notification.php b/lib/Github/Api/Notification.php
@@ -23,6 +23,7 @@ class Notification extends AbstractApi
      * @param bool          $includingRead
      * @param bool          $participating
      * @param DateTime|null $since
+     * @param DateTime|null $before
      *
      * @return array array of notifications
      */

diff --git a/lib/Github/Api/Organization.php b/lib/Github/Api/Organization.php
@@ -58,14 +58,22 @@ public function update($organization, array $params)
      *
      * @return array the repositories
      */
-    public function repositories($organization, $type = 'all', $page = 1, $sort = 'created', $direction = 'desc')
+    public function repositories($organization, $type = 'all', $page = 1, $sort = null, $direction = null)
     {
-        return $this->get('/orgs/'.rawurlencode($organization).'/repos', [
+        $parameters = [
             'type' => $type,
             'page' => $page,
-            'sort' => $sort,
-            'direction' => $direction,
-        ]);
+        ];
+
+        if($sort !== null){
+            $parameters['sort'] = $sort;
+        }
+
+        if($direction !== null){
+            $parameters['direction'] = $direction;
+        }
+
+        return $this->get('/orgs/'.rawurlencode($organization).'/repos', $parameters);
     }
 
     /**

diff --git a/test/Github/Tests/Api/OrganizationTest.php b/test/Github/Tests/Api/OrganizationTest.php
@@ -62,7 +62,7 @@ public function shouldGetOrganizationRepositories()
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('get')
-            ->with('/orgs/KnpLabs/repos', ['type' => 'all', 'page' => 1, 'sort' => 'created', 'direction' => 'desc'])
+            ->with('/orgs/KnpLabs/repos', ['type' => 'all', 'page' => 1])
             ->will($this->returnValue($expectedArray));
 
         $this->assertEquals($expectedArray, $api->repositories('KnpLabs'));