Fixing temporary file unlink when header or footer html is an URL. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing temporary file unlink when header or footer html is an URL.
|
👍 |
|
I agree, this fix is really useful when you use url in header-html / footer-html (an exception is thrown currently... :() |
|
Hi! @pilot any chance to merge this? |
pilot
added a commit
that referenced
this pull request
Oct 14, 2014
Fixing temporary file unlink when header or footer html is an URL.
|
@nullziu thanks! |
|
@pilot you're welcome, happy to help! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pull request #106 snappy tries to unlink URL-s aswell, throwing
unlink(): http does not allow unlinking.