Linux version is not executable by default

[MCOfficer]

Describe the bug

When extracting the current release's self-contained version, the file OpenDirectoryDownloader does not have an executable bit set. (I assume this is the same with the non-self-contained version).

To Reproduce
Steps to reproduce the behavior:

1. Download the current release to a linux machine
2. Extract using 7z, others should also work
3. Try to run ODD

❯ ./OpenDirectoryDownloader --version                          
zsh: permission denied: ./OpenDirectoryDownloader 

Expected behavior
The zip should retain unix permissions.

This is likely because the build runs on windows, which can't retain unix permissions due to its own filesystem:

OpenDirectoryDownloader/.github/workflows/main.yml

Line 13 in 39ebd32

runs-on: windows-latest

If you want, i can improve the workflow to run on all OSs in parallel, which should also get rid of this issue.

Desktop (please complete the following information):

• OS: Ubuntu 18.04.5
• Version: v1.9.1.0 self-contained, also happened with earlier versions.

[KoalaBear84]

Yes, tried to fix that on Saturday, but indeed didn't work. I guess I have to do move it into different jobs then and use artifacts on more places.. :)

15cdadc

[MCOfficer]

Unless i'm mistaken one can also get rid of a lot of duplicate code by running it in a matrix. Shall I try it?

[KoalaBear84]

Correct. It was like that before, and at that time I didn't understand the artifacts thing completely to make it work.

There is one caveat, and that's the Linux x64 thing that will release a Docker Hub image that needs to still work.

It would be nice if you can get it to work.

[MCOfficer]

Do you have a better word for "non-self-contained", because this is kinda confusing.

[KoalaBear84]

Normal? 😂

[MCOfficer]

hm.

normal it is ¯\_(ツ)_/¯

[KoalaBear84]

You are really doing a good job, nice to see you can do if statements in yaml, didn't have time to check all that before.

Ahh, I see already, when the first build and release finishes, it will immediately send a release email with only some files which are already uploaded.

So it needs to be a separate build job, and you can upload them all as artifacts. It will also append the commit text for every build as it seems. Probably need the same matrix for both jobs to be able to dynamically download the artifacts back.

[MCOfficer]

It's a bit of a hassle, but if that's an issue i can certainly do it. It's also a nice workaround for softprops/action-gh-release#57.

[KoalaBear84]

Yes indeed, it would fix both issues.