Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports Vue3 and the switch to compiler-sfc #440

Merged
merged 9 commits into from
Jul 8, 2021
Merged

Conversation

DaveTorrey
Copy link
Contributor

@DaveTorrey DaveTorrey commented Jul 8, 2021

Q A
Bug fix? no
New feature? yes
Tests pass? yes
Fixed tickets #386

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #440 (df5138d) into master (f69e200) will increase coverage by 0.59%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   70.83%   71.42%   +0.59%     
==========================================
  Files           5        5              
  Lines          48       56       +8     
  Branches       11       16       +5     
==========================================
+ Hits           34       40       +6     
- Misses         11       13       +2     
  Partials        3        3              
Impacted Files Coverage Δ
lib/core/vueScriptExtractor.js 100.00% <100.00%> (ø)
lib/core/issers.js 0.00% <0.00%> (ø)
lib/core/renderer.js 100.00% <0.00%> (ø)
lib/core/getTemplatePath.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 713bc25...df5138d. Read the comment docs.

@Kocal Kocal merged commit 1bf90f5 into Kocal:master Jul 8, 2021
Kocal added a commit that referenced this pull request Jul 8, 2021
BREAKING CHANGES: Drop Vue 2 support, add Vue 3 support, thanks to @DaveTorrey!

Vue 2 support is still available on https://github.com/Kocal/jsdoc-vuejs/tree/3.x branch.

Co-authored-by: Dave Torrey <david.j.torrey@gmail.com>
Co-authored-by: Hugo Alliaume <hugo@alliau.me>
Kocal added a commit that referenced this pull request Jul 8, 2021
BREAKING CHANGE: Drop Vue 2 support, add Vue 3 support, thanks to @DaveTorrey!

Vue 2 support is still available on https://github.com/Kocal/jsdoc-vuejs/tree/3.x branch.

Co-authored-by: Dave Torrey <david.j.torrey@gmail.com>
Co-authored-by: Hugo Alliaume <hugo@alliau.me>
@Kocal Kocal mentioned this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants