Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Retry and timeout are misconfigured" as per default settings #526

Open
amo13 opened this issue Apr 3, 2021 · 7 comments
Open

"Retry and timeout are misconfigured" as per default settings #526

amo13 opened this issue Apr 3, 2021 · 7 comments

Comments

@amo13
Copy link
Contributor

amo13 commented Apr 3, 2021

On a fresh installation without altered configuration, the new warning pops up:

/usr/lib/python3.9/site-packages/django_q/conf.py:136: UserWarning: Retry and timeout are misconfigured. Set retry larger than timeout, 
        failure to do so will cause the tasks to be retriggered before completion. 
        See https://django-q.readthedocs.io/en/latest/configure.html#retry for details.
  warn("""Retry and timeout are misconfigured. Set retry larger than timeout,

Since I did not change any configuration, I looked up the default conf.py in this repo to find that timeout is set to none while retry is set to 60s.
Should the the timeout in the default conf.py be set to an appropriate value so that it does not trigger the new warning after an unaltered default installation?

@Koed00
Copy link
Owner

Koed00 commented Apr 3, 2021

Yes, and the docs need to be updated too. It happened because of a recent PR. Either that or we don't show the warning on no timeout configured.

@amo13
Copy link
Contributor Author

amo13 commented Apr 3, 2021

Awesome! I can create the pull request, but I don't know what timeout value would be sane. 30? 59?

amo13 added a commit to amo13/django-q that referenced this issue Apr 22, 2021
amo13 added a commit to amo13/django-q that referenced this issue Apr 22, 2021
Koed00 pushed a commit that referenced this issue May 1, 2021
@mike-bell-gettogetherai

I just had this issue on a fresh install with version 1.3.9 which is surprising since it looks like this PR was merged back in May...

@amo13
Copy link
Contributor Author

amo13 commented Aug 24, 2021

It was not merged, only the modification in the documentation. I suggested the corresponding code modification in a separate pull request, but my code edits seem to create trouble elsewhere. Unfortunately, I do not know any python and cannot help any further.

#537

@mike-bell-gettogetherai

Ah ok, thanks for confirming!

@seaturtlecode
Copy link

Is this warning safe to ignore if there is no timeout configured?

@abhijeet-electrum
Copy link

abhijeet-electrum commented Jul 15, 2022

The same issue comes when we set the timeout value to None.

How can we set timeout value to None and not get this warning? Tried keeping retry value as None, but same warning persist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants