Replaces async occurrences with alternatives #306
Conversation
P-EB
commented
Jul 16, 2018
P-EB
commented
- async is now a reserved word in python3.7
- Rename async function to enqueue
- Rename all async_ functions to enqueue_
- Rename Async class to AsyncTask
- Updates the docs.
* async is now a reserved word in python3.7 * Rename async function to enqueue * Rename all async_ functions to enqueue_ * Rename Async class to AsyncTask * Updates the docs.
|
@Koed00 here! |
|
@Koed00 did you get some time to review these changes? Especially, the change of the naming convention, as it's an API change. |
|
@Koed00 it would be awesome to have this available on PyPI as a lot of projects (including ours) are currently upgrading to the new Python 3.7 release. |
|
any advice, how upstream will rename the module? |
|
@doko42 what module? Did I miss a filename in my patch? :/ |
|
no, I'd just like to see an approval / integration of this patch before pulling it into any distro package. |
|
I agree, I'll delay until @Koed00 is there and answers :) |
|
Sorry everyone. Between holidays and my job , it's been hard to put some time in this. I did review the code and it's all good, except that I just didn't like the word 'enqueue'. |
|
Sure, I'm fine with this. :) I'll wait for your next release before releasing into debian. |
"async" is a reserved word in Python 3.7, so django-q had to rename their thing. Unfortunately they didn't make documentation or CHANGELOG changes to go with the code changes and releases, so see Koed00/django-q#306 and Koed00/django-q#310 for more information.
