Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'force_str' instead of deprecated 'force_text' #448

Merged
merged 1 commit into from Jun 17, 2020
Merged

Use 'force_str' instead of deprecated 'force_text' #448

merged 1 commit into from Jun 17, 2020

Conversation

edthrn
Copy link
Contributor

@edthrn edthrn commented Jun 17, 2020

Starting from Django 3.0, force_text() is deprecated in favour of force_str()

According to the doc, the use of force_text() was only kept for backwards compatibility with Python 2, and Django-Q removed 2.7 support earlier this year.

Ref: https://docs.djangoproject.com/en/3.0/ref/utils/#django.utils.encoding.force_text

Starting from Django 3.0, `force_text()` is deprecated in favour of `force_str()`
Ref: https://docs.djangoproject.com/en/3.0/ref/utils/#django.utils.encoding.force_text
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #448 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files          44       44           
  Lines        2933     2933           
=======================================
  Hits         2662     2662           
  Misses        271      271           
Impacted Files Coverage Δ
django_q/core_signing.py 84.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22dc790...dfea90f. Read the comment docs.

@Koed00 Koed00 merged commit 58d71da into Koed00:master Jun 17, 2020
@Koed00
Copy link
Owner

Koed00 commented Jun 17, 2020

Merci

@edthrn
Copy link
Contributor Author

edthrn commented Jun 17, 2020

Wow that was fast 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants