Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model.__unicode__() has no effect in Python 3.X #479

Merged
merged 1 commit into from Oct 20, 2020

Conversation

alx-sdv
Copy link
Contributor

@alx-sdv alx-sdv commented Oct 5, 2020

This PR fixes displaying "Schedule object (1)" instead of Schedule.func in django-admin history & messages.
Python 2 support seems to be dropped, so I replaced unicode with str.
Tested on Python 3.8.2, Django 3.1

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020

Codecov Report

Merging #479 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          47       47           
  Lines        3051     3051           
=======================================
  Hits         2782     2782           
  Misses        269      269           
Impacted Files Coverage Δ
django_q/models.py 98.22% <100.00%> (ø)
django_q/tests/test_cluster.py 100.00% <100.00%> (ø)
django_q/tests/test_scheduler.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4c357...28197dc. Read the comment docs.

@Koed00 Koed00 merged commit d97e7d7 into Koed00:master Oct 20, 2020
@Koed00
Copy link
Owner

Koed00 commented Oct 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants