Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependencies #28

Merged
merged 10 commits into from
Dec 16, 2023
Merged

Remove unneeded dependencies #28

merged 10 commits into from
Dec 16, 2023

Conversation

Koeng101
Copy link
Owner

This PR removes dependencies that are not strictly needed.

@Koeng101
Copy link
Owner Author

Koeng101 commented Dec 15, 2023

The following were/are going to be added directly to source tree: They're pretty much complete (no updates in years), so it is easier to just manage them internally:

  • svb
  • intel-cpuid (used by svb only)
  • murmur3
  • wordwrap

On the top level go.mod should be replaced with a go.work file, with the submodule of the lib of DNA design being separate from the services. lib right now will only have Go project dependencies, but this may change if there is a sufficiently useful package that cannot be integrated into the source tree directly. In addition to lib, we will also have a wasm_lib directory with wasm dependencies, like minimap2, diamond, and sqlite (plus the required wazero). This repo will have minimal dependencies as well.

Once we get into services, it's a little bit more of the wild west. We will at least require:

  • github.com/sashabaranov/go-openai (for communicating with LLMs, actively developed)
  • github.com/yuin/gopher-lua (for running lua, actively developed)
  • github.com/oapi-codegen/runtime (for generating OpenAPIs)
  • github.com/getkin/kin-openapi (for handling OpenAPI specs)
  • github.com/caddyserver/caddy (for scraping websites like iGEM or Addgene)

Plus associated javascript like scalar

@Koeng101
Copy link
Owner Author

Koeng101 commented Dec 15, 2023

Forgot to add: in Go 1.22 they're going to add better routing to the std, removing the need for chi. So that's nice.

@Koeng101
Copy link
Owner Author

Keeping github.com/google/go-cmp for checking equivalence of lists and golang.org/x/sync for errgroup.

@Koeng101
Copy link
Owner Author

Koeng101 commented Dec 16, 2023

Big todos:

  • Update seqhash to be more explicit about version 1 depreciation
  • Write about the 4 internal packages (svb, cpuid, wordwrap, and murmur)
  • Refactor codon completely. I am removing a lot of cruft, and really slimming down the implementation. Do this in a separate PR.

@Koeng101 Koeng101 merged commit 37c32f8 into main Dec 16, 2023
3 checks passed
@Koeng101 Koeng101 deleted the removeDeps1 branch December 16, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant