feat: Use common motor_state values for Bosch & Lumi devices (#7470)

* fix: Use common `motor_state` values for Bosch BCMT-SLZ Use `stopped` instead of `idle` so integrations can expect a common, minimum set of `motor_state` values. * fix: Use common `motor_state` values for Lumi devices
Koenkk · Apr 30, 2024 · 5f578b1 · 5f578b1
1 parent 6a544cc
commit 5f578b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/devices/bosch.ts b/src/devices/bosch.ts
@@ -48,7 +48,7 @@ const stateDeviceMode: KeyValue = {
 
 // BMCT
 const stateMotor: KeyValue = {
-    'idle': 0x00,
+    'stopped': 0x00,
     'opening': 0x01,
     'closing': 0x02,
 };

diff --git a/src/devices/lumi.ts b/src/devices/lumi.ts
@@ -1853,7 +1853,7 @@ const definitions: Definition[] = [
         exposes: [e.cover_position().setAccess('state', ea.ALL), e.battery(),
             e.binary('running', ea.STATE, true, false)
                 .withDescription('Whether the motor is moving or not'),
-            e.enum('motor_state', ea.STATE, ['closing', 'opening', 'stop'])
+            e.enum('motor_state', ea.STATE, ['closing', 'opening', 'stopped'])
                 .withDescription('The current state of the motor.'), e.power_outage_count()],
         extend: [lumiZigbeeOTA()],
     },
@@ -1881,7 +1881,7 @@ const definitions: Definition[] = [
                 .withDescription('Pulling curtains by hand starts the motor'),
             e.binary('running', ea.STATE, true, false)
                 .withDescription('Whether the motor is moving or not'),
-            e.enum('motor_state', ea.STATE, ['closing', 'opening', 'stop'])
+            e.enum('motor_state', ea.STATE, ['closing', 'opening', 'stopped'])
                 .withDescription('The current state of the motor.'), e.power_outage_count()],
         extend: [lumiZigbeeOTA()],
     },
@@ -1906,7 +1906,7 @@ const definitions: Definition[] = [
         exposes: [e.cover_position().setAccess('state', ea.ALL), e.battery().withAccess(ea.STATE_GET), e.device_temperature(),
             e.binary('charging_status', ea.STATE_GET, true, false)
                 .withDescription('The current charging status.'),
-            e.enum('motor_state', ea.STATE, ['declining', 'rising', 'pause', 'blocked'])
+            e.enum('motor_state', ea.STATE, ['closing', 'opening', 'stopped', 'blocked'])
                 .withDescription('The current state of the motor.'),
             e.binary('running', ea.STATE, true, false)
                 .withDescription('Whether the motor is moving or not')],