deps zigbee-herdsman

[G1K]

c0e84ec

when refactoring, a dependency was added zigbee-herdsmannow it is in two directories and takes up more space which is not very much on xiaomi gw. Is it possible to do without this direct relationship?

[Koenkk]

The only reason for this dependency is the manufacturer codes (

zigbee-herdsman-converters/converters/toZigbee.js

Line 11 in 3ed4ad4

const manufacturerOptions = {

). Can you create a PR to move this back in and remove the zigbee-herdsman dependency?

[G1K]

I do not know how to solve this nicely and updateable. I can only offer to transfer static codes of Manufacturers.

Is such a solution suitable for PR?

[Koenkk]

I do not know how to solve this nicely and updateable. I can only offer to transfer static codes of Manufacturers.

Yes, exactly what I meant!

[G1K]

I tried to do this, but herdsman is still used for herdsman.Zcl.Status, it used to be in common.js. My suggestion is to add herdsman as a dev dependency or you need to move all const zcl into a separate package.

[G1K]

Or you can still try updating the version of herdsman along with the main repository. Then the npm shouldn't pull up a specific version.

[Koenkk]

I tried to do this, but herdsman is still used for herdsman.Zcl.Status, it used to be in common.js. My suggestion is to add herdsman as a dev dependency or you need to move all const zcl into a separate package.

I don't think it's an option. That would mean it not always available while it is used in production code

Or you can still try updating the version of herdsman along with the main repository. Then the npm shouldn't pull up a specific version.

That seems the best solution for now. With next z2m release I will make sure zigbee-herdsman-converters and zigbee2mqtt use the exact same zigbee-herdsman version.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days