Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saswell exposes running_state but no conversion defined #2603

Closed
philipp2310 opened this issue May 19, 2021 · 1 comment
Closed

saswell exposes running_state but no conversion defined #2603

philipp2310 opened this issue May 19, 2021 · 1 comment

Comments

@philipp2310
Copy link

zigbee-herdsman-converters/devices/saswell.js is exposing "running_state" but has no toZigbee conversion defined for it.

If I understand it correctly tz.thermostat_running_state should be included?

Sorry, don't understand it good enough to just make a PR for my guess :)

2021-05-20 00:53:11: No converter available for 'running_state' ()

Not sure if this would add the running_state to the published MQTT message as well:

MQTT publish: topic 'zigbee2mqtt/0x847xxx', 
payload '{
  "anti_scaling":"ON",
  "away_mode":"OFF",
  "battery_low":false,
  "child_lock":"LOCK",
  "current_heating_setpoint":17,
  "frost_detection":"ON",
  "linkquality":0,
  "local_temperature":18.1,
  "local_temperature_calibration":0,
  "preset_mode":"none",
  "system_mode":"auto",
  "window_detection":"ON"
}'

And thanks for the awesome software!

@Koenkk
Copy link
Owner

Koenkk commented May 20, 2021

Thermostat doesn't support it indeed, removed.

Changes will be available in the dev branch in a few hours from now. (https://www.zigbee2mqtt.io/how_tos/how-to-switch-to-dev-branch.html)

@Koenkk Koenkk closed this as completed May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants