Add vendor Imhotep creation and its devices support #6478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add vendor Imhotep creation and support of its E-Ctrl range heaters and the connection bridge device BRI4P
Koenkk
reviewed
Nov 15, 2023
src/devices/imhotepcreation.ts
Outdated
| return features; | ||
| }, | ||
| configure: async (device, coordinatorEndpoint, logger) => { | ||
| if (typeof device !== 'undefined') { |
There was a problem hiding this comment.
Thanks for this feedback, we have removed this check
|
Note to self; after this merge Koenkk/zigbee2mqtt.io#2331 |
Koenkk
reviewed
Nov 16, 2023
| {vendor: 'Imhotep Creation', model: 'RSS E-Ctrl', description: 'Towel heater thermostat THIE (TH ECTRL) and compliant', | ||
| fingerprint: [{modelID: 'RSS E-Ctrl'}]}, | ||
| {vendor: 'Imhotep Creation', model: 'RPH E-Ctrl', description: 'Panel radiant heater thermostat MPHIE (NRPH) and compliant', | ||
| fingerprint: [{modelID: 'RPH E-Ctrl'}]}, |
There was a problem hiding this comment.
I missed the whitelabels here, could you add the pictures for it back in Koenkk/zigbee2mqtt.io#2331 ?
Koenkk
added a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vendor Imhotep creation and support of its E-Ctrl range heaters and the connection bridge device BRI4P