-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vendor Imhotep creation and its devices support #6478
Conversation
Add vendor Imhotep creation and support of its E-Ctrl range heaters and the connection bridge device BRI4P
src/devices/imhotepcreation.ts
Outdated
return features; | ||
}, | ||
configure: async (device, coordinatorEndpoint, logger) => { | ||
if (typeof device !== 'undefined') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this check is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this feedback, we have removed this check
Note to self; after this merge Koenkk/zigbee2mqtt.io#2331 |
{vendor: 'Imhotep Creation', model: 'RSS E-Ctrl', description: 'Towel heater thermostat THIE (TH ECTRL) and compliant', | ||
fingerprint: [{modelID: 'RSS E-Ctrl'}]}, | ||
{vendor: 'Imhotep Creation', model: 'RPH E-Ctrl', description: 'Panel radiant heater thermostat MPHIE (NRPH) and compliant', | ||
fingerprint: [{modelID: 'RPH E-Ctrl'}]}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the whitelabels here, could you add the pictures for it back in Koenkk/zigbee2mqtt.io#2331 ?
Add vendor Imhotep creation and support of its E-Ctrl range heaters and the connection bridge device BRI4P