fix: move other devices from 6865 to modernExtend.quirkPendingRequestTimeout #6874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorge
force-pushed
the
followup_6865
branch
2 times, most recently
from
7e39e9f
to
7df078c
Compare
|
Wow I'm really not awake, as you change it in a later commit, and simply accepting both is gonna be a pain. |
Koenkk
reviewed
Jan 10, 2024
|
Looks good, thanks! |
|
There is still some follow up work for zh I discovered #6865 (comment) @slugzero is gonna look at it. I might have time later next week too if they don't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't need to add anything to the type, as it still takes number :) read over that yesterday.