Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta option to disable return value on /set for cover_position_tilt #7438

Merged
merged 10 commits into from
Apr 28, 2024

Conversation

burmistrzak
Copy link
Contributor

Implements a lightly customized cover_position_tilt converter, that doesn't return the set value, because we already have reporting for currentPositionLiftPercentage configured.

Nothing more. 😊

Should help with itavero/homebridge-z2m#852 (comment)

Custom converter that does not return the set value because BMCT-SLZ has reporting configured.
Where did that come from?
@Koenkk
Copy link
Owner

Koenkk commented Apr 25, 2024

that doesn't return the set value,

Does this cause any problems?

@burmistrzak
Copy link
Contributor Author

burmistrzak commented Apr 25, 2024

that doesn't return the set value,

Does this cause any problems?

Not with the BMCT-SLZ, because the device starts reporting its new position immediately.
However, having the /set command itself return the destined target position instantly can cause a bunch of weird stuff downstream.

100
0    [target position from /set]
100
99
98
97
[...]

Very simple devices that don't provide additional details like e.g. motor_state might become a bit harder to integrate, because the direction of movement no longer can be determined from a single status update by utilizing this particular quirk.

src/devices/bosch.ts Outdated Show resolved Hide resolved
@burmistrzak burmistrzak changed the title Add custom cover_position_tilt for Bosch BMCT-SLZ Add meta option to disable return value on /set for cover_position_tilt Apr 27, 2024
@burmistrzak burmistrzak marked this pull request as ready for review April 27, 2024 16:30
@burmistrzak burmistrzak requested a review from Koenkk April 27, 2024 16:31
@Koenkk Koenkk merged commit badb0e5 into Koenkk:master Apr 28, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Apr 28, 2024

Thanks!

@burmistrzak burmistrzak deleted the fix-bcmt-slz-tzLocal branch April 28, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants