Fix cover_position_tilt's returned position. #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running with invert_cover unset or false, the zigbee position sent to device as 100-position. Working as intended. However it also reports back the same inverted value as the new state. This is wrong. When HA sets the position to 35, it gets back 65. Even worse, if it want to open the cover by sending it 100 (=HA-open), it gets back a 0 (=HA-closed) which then disabled the down arrow, making it annoying to figure out what just happened. Of course, when invert_cover=true, no translation happens and setting it to 35, returns 35.
|
Nasty bug, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with invert_cover unset or false, the zigbee position sent to device as 100-position. Working as intended. However it also reports back the same inverted value as the new state. This is wrong. When HA sets the position to 35, it gets back 65.
Even worse, if it want to open the cover by sending it 100 (=HA-open), it gets back a 0 (=HA-closed) which then disabled the down arrow, making it annoying to figure out what just happened.
Of course, when invert_cover=true, no translation happens and setting it to 35, returns 35.