Fix Iris 3210-L and Centralite 4257050-ZHAC configure #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this does not need a bump of the configureKey, if configure failed it will always re-execute it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Koen,
I noticed that configuration was failing on my Iris 3210-L smart plugs. The error was
UNSUPPORTED_ATTRIBUTE, and it turns out that they (at least the two I have) don't support theacVoltageMultiplieroracVoltageDivisorattributes of thehaElectricalMeasurementcluster. The voltage is reported in volts (so it needs no multiplier or divisor).Apparently I broke this in #705 😞 , and Centralite 4257050-ZHAC dimming plugs are also affected. I'm pretty surprised this got past me (and stood for a year), but as I have never been able to update the firmware on these things, I'm not sure how anything could have changed behavior-wise... and it is definitely throwing errors now.
With these changes, my 3210-L plugs and 4257050-ZHAC dimming plugs now configure fine. I'm not sure if this needs a
configureKeybump or not.I also noticed some unused code (due to #1363) and removed it.