Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scene error messages #1815

Merged
merged 3 commits into from Nov 28, 2020
Merged

Improve scene error messages #1815

merged 3 commits into from Nov 28, 2020

Conversation

sjorge
Copy link
Sponsor Contributor

@sjorge sjorge commented Nov 28, 2020

See Koenkk/zigbee2mqtt#5102,

  • warn when we can't restore state for a scene_recall (but don't error, as we still send the zigbee command and the device could have still have scenes we don't know about)
  • split generic into missing ID and wrong payload type for scene_add

@Koenkk
Copy link
Owner

Koenkk commented Nov 28, 2020

Thanks!

@Koenkk Koenkk merged commit d5c0dab into Koenkk:master Nov 28, 2020
@sjorge sjorge deleted the scene_msgs branch March 2, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants