Сhanged priority to use external converters

[xyzroe]

findByZigbeeModel and findByDevice return last candidate of all possible

Please check is it possible to do like this?
I got everything working.

[Koenkk]

Instead of doing this I prefer to add an additional parameter to

zigbee-herdsman-converters/index.js

Line 39 in 3ec3075

function addDefinition(definition) {

called addInFront (default false) and set that to true here: https://github.com/Koenkk/zigbee2mqtt/blob/master/lib/extension/externalConverters.js#L13

[xyzroe]

And then, at

zigbee-herdsman-converters/index.js

Line 59 in 3ec3075

function findByZigbeeModel(zigbeeModel) {

and

zigbee-herdsman-converters/index.js

Line 68 in 3ec3075

function findByDevice(device) {

check if exists any item with addInFront = true, return than one? Right?
Ok I'l work on it later.

[xyzroe]

I tried, but I'm not so good at tests writing.
But I checked everything manually.
I am my opinion everything works as expected.

[nurikk]

Instead of doing this I prefer to add an additional parameter to

zigbee-herdsman-converters/index.js

Line 39 in 3ec3075

function addDefinition(definition) {

called addInFront (default false) and set that to true here: https://github.com/Koenkk/zigbee2mqtt/blob/master/lib/extension/externalConverters.js#L13

Why do we need to do this? Why not let to override internal converter by default? This behaviour is quite safe, since user need to do two steps:

1. put external converter in data folder
2. add external converter into configuration.json
   This can't cause any unexpected behaviour.

If we implement loading in this way, then we just need to pick last registered converter:

zigbee-herdsman-converters/index.js

Line 65 in 8466c08

return candidates ? candidates[0] : null;

- return candidates ? candidates[0] : null; 
+ return candidates ? candidates[candidates.length - 1] : null;

[xyzroe]

I started from made returning last candidate of all possible, it is the easiest way to implement this function.

[Koenkk]

@xyzroe sorry to switch opinions, but I think the solution provided by @nurikk is better indeed.

So the only changed required here is:

- return candidates ? candidates[0] : null; 
+ return candidates ? candidates[candidates.length - 1] : null;

[xyzroe]

How about findByDevice() ?
I think it is also necessary to change the order

[nurikk]

How about findByDevice() ?
I think it is also necessary to change the order

Yes, apply this logic everywhere where it necessary. I just gave small example

[xyzroe]

returned everything as it was originally in the commit e064dd9

[Koenkk]

Thanks!