Lumi.plug.mmeu01.part two improvement #1874

PeterVoronov · 2020-12-07T14:15:41Z

Extending functionality for lumi.plug.mmeu01, i.e. ZNCZ04LM:
New states:
auto_off - auto off state, to switch the plug off in case of low level of consumption (< 2.6 W);
consumer_connected - show the status of connection of the consume device(s) to the plug;
led_disabled - show the state of the led disable at night feature;
power_outage_memory - show the state of power outage memory feature;
New switches:
auto_off - auto off feature, to switch the plug off in case of low level of consumption (<2.6 W);
led_disabled - feature to set led disabled at night;
Changes to be committed:
modified: converters/fromZigbee.js
modified: converters/toZigbee.js
modified: devices.js
modified: lib/exposes.js

… functionality of lumi.plug.mmeu01, i.e. ZNCZ04LM: New states: auto_off - auto off state, to swith the plug off in case of low level of consumption; consumer_connected - show the status of connection of the customer to the plug; led_disabled - show the state of the led disable feature; power_outage_memory - show the state of power outage memory feature; New switches: auto_off - auto off feature, to swith the plug off in case of low level of consumption; led_disabled - feature to set led disabled; power_outage_memory - feature to set power outage memory enabled or disabled; Changes to be committed: modified: converters/fromZigbee.js modified: converters/toZigbee.js modified: devices.js modified: lib/exposes.js

Some description of a states tunig Changes to be committed: modified: lib/exposes.js

PeterVoronov · 2020-12-07T14:18:29Z

Hello,
there is my second improvement for this plugs ...
Most useful things:
Consumer connected state and possibility to check, is power outage memory is set on or off.

Koenkk · 2020-12-07T16:07:18Z

lib/exposes.js

@@ -303,12 +303,14 @@ module.exports = {
    presets: {
        action: (values) => new Enum('action', access.STATE, values).withDescription('Triggered action (e.g. a button click)'),
        aqi: () => new Numeric('aqi', access.STATE).withDescription('Air quality index'),
+        auto_off: () => new Binary('auto_off', access.STATE, true, false).withDescription('Indicates whether the device has auto off with low consumer load functionality enabled or not'),


access should be access.STATE_SET here (since you can set it via toZigbee), same goes for power_outage_memory and led_disabled.

Correct me, if I'm wrong, but I understand this way:
STATE_SET - only for set
STATE_GET - only for get
STATE - for both

And I have more strategical question:
Should be such states not binary, but like a switch - literally "on/off' ?

Koenkk · 2020-12-07T16:07:57Z

lib/exposes.js

@@ -325,6 +327,7 @@ module.exports = {
        illuminance: () => new Numeric('illuminance', access.STATE).withDescription('Raw measured illuminance'),
        illuminance_lux: () => new Numeric('illuminance_lux', access.STATE).withUnit('lx').withDescription('Measured illuminance in lux'),
        keypad_lockout: () => new Lock().withState('keypad_lockout', '1', '0', 'Enables/disables physical input on the device'),
+        led_disabled: () => new Binary('led_disabled', access.STATE, true, false).withDescription('Indicates whether the device has LED disable at night state or not'),


I think we should rename this to led_disabled_night because led_disabled makes me think the led is always disabled.

Koenkk · 2020-12-07T16:09:00Z

converters/fromZigbee.js

+                    default:
+                        // if (meta.logger) meta.logger.debug(`plug.mmeu01: unknown index $(index) with value ${value}`);
+                    }
+                    if (meta.logger) meta.logger.debug(`plug.mmeu01: recorded index ${index} with value ${value}`);


I don't think we should always log here. maybe only in default case?

Same goes for all logging below e.g. if (meta.logger) meta.logger.debug(plug.mmeu01: attr. 513 (pwr_out_mem) has value ${msg.data['513']});

Koenkk · 2020-12-07T16:10:12Z

converters/fromZigbee.js

+            }
+            if (msg.data.hasOwnProperty('523')) {
+                // 0x020B
+                if (meta.logger) meta.logger.debug(`plug.mmeu01: attribute 523 (max_load) has value ${msg.data['523']}`);


Nothing is set in the payload here.

It's for detecting, but ok, will add

Koenkk · 2020-12-07T16:11:39Z

converters/fromZigbee.js

@@ -1643,20 +1643,62 @@ const converters = {
                    default:
                        // if (meta.logger) meta.logger.debug(`plug.mmeu01: unknown vtype=${data[i+1]}, pos=${i+1}`);
                    }
-                    payload[index] = value;
-                    // if (meta.logger) meta.logger.debug(`plug.mmeu01: recorded index ${index} with value ${value}`);
+                    switch (index) {


I think we should compact this code with if else. e.g.

if (index === 3) payload.temperature = calibrateAndPrecisionRoundOptions(value, options, 'temperature'); else if (index === 100) payload.state = value === 1 ? 'ON' : 'OFF'; etc...

Sames goes for all if's here: https://github.com/Koenkk/zigbee-herdsman-converters/pull/1874/files#diff-b676ab0df4d49b8572967cb4c92a2dc6264091131f6b1828ca13d0f9656e367aR1677

Not see a big difference, but - as you wish ;-)

Koenkk · 2020-12-07T16:14:00Z

Put some comments, but would like to thank you a lot, personally I'm very interested in the auto_off function as I have my kettle connected to this device.

- removed extra logging; - led_disabled renamed to led-disabled_night; - added previously empty ppayload - consumer_overload Changes to be committed: modified: converters/fromZigbee.js modified: converters/toZigbee.js modified: devices.js modified: lib/exposes.js

PeterVoronov · 2020-12-07T19:22:45Z

Put some comments, but would like to thank you a lot, personally I'm very interested in the auto_off function as I have my kettle connected to this device.

Thanks and You are welcome ;-)

Changed access.STATE to access.STATE_SET for changable states: - auto_off - power_outage_memory - led_disabled_night Changes to be committed: modified: lib/exposes.js

PeterVoronov · 2020-12-07T19:57:02Z

Done

In fact it is a value of W, not a boolean one Changes to be committed: modified: converters/fromZigbee.js modified: lib/exposes.js

PeterVoronov · 2020-12-08T16:24:48Z

finally done ;-)
At least it all working for me ...

Koenkk · 2020-12-08T19:08:12Z

big thanks!

Koenkk · 2020-12-08T20:04:14Z

@PeterVoronov how does the auto_off work? I've tested with a kettle but the plug does not automatically turn off once the water is cooked (checked that the power is 0). The power outage works correctly

PeterVoronov · 2020-12-08T20:48:50Z

@PeterVoronov how does the auto_off work? I've tested with a kettle but the plug does not automatically turn off once the water is cooked (checked that the power is 0). The power outage works correctly

In my case it switched off after 20 minutes after I set the auto_off on a system without load.
There is listed a parameter for the power threshold , but i didn't saw a parameter for the timeout.

PeterVoronov added 2 commits December 7, 2020 12:49

On branch lumi.plug.mmeu01.part-two

73bfb78

Some description of a states tunig Changes to be committed: modified: lib/exposes.js

Koenkk reviewed Dec 7, 2020

View reviewed changes

PeterVoronov added 3 commits December 7, 2020 21:25

Fix lint typo

f5ab502

On branch lumi.plug.mmeu01.part-two applying Koenkk's recommendation

78b9947

Changed access.STATE to access.STATE_SET for changable states: - auto_off - power_outage_memory - led_disabled_night Changes to be committed: modified: lib/exposes.js

replace case constuction by if ... if else

d0c46a3

PeterVoronov added 2 commits December 7, 2020 22:16

fix typo in debug log

f4fce04

On branch lumi.plug.mmeu01.part-two there is a fix for consumer_overload

7323a73

In fact it is a value of W, not a boolean one Changes to be committed: modified: converters/fromZigbee.js modified: lib/exposes.js

Koenkk added 4 commits December 8, 2020 19:55

Update exposes.js

052e358

Update devices.js

7f63114

Update toZigbee.js

56e4f86

Update devices.js

6edf5d7

Koenkk merged commit e258710 into Koenkk:master Dec 8, 2020

Koenkk added a commit that referenced this pull request Dec 9, 2020

Clarify auto_off. #1874 (comment)

bfbf71c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lumi.plug.mmeu01.part two improvement #1874

Lumi.plug.mmeu01.part two improvement #1874

PeterVoronov commented Dec 7, 2020

PeterVoronov commented Dec 7, 2020

Koenkk Dec 7, 2020

PeterVoronov Dec 7, 2020

PeterVoronov Dec 7, 2020

Koenkk Dec 7, 2020

PeterVoronov Dec 7, 2020

Koenkk Dec 7, 2020

Koenkk Dec 7, 2020

PeterVoronov Dec 7, 2020

Koenkk Dec 7, 2020

PeterVoronov Dec 7, 2020

Koenkk Dec 7, 2020

PeterVoronov Dec 7, 2020

Koenkk commented Dec 7, 2020

PeterVoronov commented Dec 7, 2020

PeterVoronov commented Dec 7, 2020

PeterVoronov commented Dec 8, 2020

Koenkk commented Dec 8, 2020

Koenkk commented Dec 8, 2020

PeterVoronov commented Dec 8, 2020

Lumi.plug.mmeu01.part two improvement #1874

Lumi.plug.mmeu01.part two improvement #1874

Conversation

PeterVoronov commented Dec 7, 2020

PeterVoronov commented Dec 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Koenkk commented Dec 7, 2020

PeterVoronov commented Dec 7, 2020

PeterVoronov commented Dec 7, 2020

PeterVoronov commented Dec 8, 2020

Koenkk commented Dec 8, 2020

Koenkk commented Dec 8, 2020

PeterVoronov commented Dec 8, 2020