Fantem MultiSensor ZB003-X #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Jan 12, 2021
devices.js
Outdated
| e.occupancy(), e.battery(), | ||
| e.illuminance().withUnit('lx'), | ||
| e.temperature(), e.humidity(), | ||
| exposes.numeric('reporting_time', exposes.access.ALL), |
There was a problem hiding this comment.
Can you also add description for all (use .withDescripition("...."))
Koenkk
reviewed
Jan 12, 2021
Koenkk
reviewed
Jan 12, 2021
Koenkk
reviewed
Jan 12, 2021
converters/fromZigbee.js
Outdated
| let val; | ||
| switch (dp) { | ||
| case 107: // 0x6b temperature | ||
| return {temperature: (value / 10).toFixed(1)}; |
There was a problem hiding this comment.
Please use calibrateAndPrecisionRoundOptions(temperature, options, 'temperature') here
Koenkk
reviewed
Jan 12, 2021
converters/fromZigbee.js
Outdated
| case 107: // 0x6b temperature | ||
| return {temperature: (value / 10).toFixed(1)}; | ||
| case 108: // 0x6c humidity | ||
| return {humidity: value}; |
There was a problem hiding this comment.
Please use calibrateAndPrecisionRoundOptions(humidity, options, 'humidity')
|
Thanks! |
dsantos21
reviewed
Feb 3, 2021
converters/fromZigbee.js
Outdated
| convert: (model, msg, publish, options, meta) => { | ||
| const zoneStatus = msg.data.zonestatus; | ||
| return { | ||
| occupancy: (zoneStatus & 1<<2) > 0, |
There was a problem hiding this comment.
Hi! I've just updated the issue #2071 with some comments about occupancy not working. After some debug, I changed my local instance and now it's working (without the bitwase operator):
occupancy: (zoneStatus & 1) > 0,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2071