Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devices.js to include support for Nue FB56+ZSW1HKJ1.7 2 gang s… #242

Closed
wants to merge 2 commits into from
Closed

Conversation

highground88
Copy link
Contributor

Confirmed working for actuations only.

@Koenkk
Copy link
Owner

Koenkk commented Jan 27, 2019

Let's first make it fully supported, when pressing the switch do you get any feedback?

@highground88
Copy link
Contributor Author

highground88 commented Jan 28, 2019

Sorry you are right. No MQTT message on pressing the switch. How do I determine what will need to be modified to do so?

Sending a valid MQTT message to turn on does result in feedback from the device, e.g. off returns the following state updates:

MQTT
2019-01-28 11:37:50Topic: zigbee2mqtt/2_gang_wall_switchQos: 0{"state":"on","device":{"ieeeAddr":"0x00124b0014afe1fb","friendlyName":"2_gang_wall_switch","type":"Router","nwkAddr":19115,"manufId":0,"manufName":"Feibit Inc co. ","powerSource":"Mains (single phase)","modelId":"FB56+ZSW1HKJ1.7","status":"offline"},"state_left":"off","state_right":"off"}

The below debug actuations don't show a unique response from the seperate buttons:

DEBUG (both switches on/off in sequence)

019-01-28T01:56:48.915Z zigbee-shepherd:af dispatchIncomingMsg(): type: incomingMsg, msg: [object Object]
2019-01-28T01:56:48.925Z zigbee-shepherd:msgHdlr IND <-- AF:incomingMsg, transId: 0
2019-01-28T01:56:48.927Z zigbee-shepherd:af dispatchIncomingMsg(): type: zclIncomingMsg, msg: [object Object]
  zigbee2mqtt:debug 2019-1-28 11:56:48 Received zigbee message of type 'attReport' with data '{"cid":"genOnOff","data":{"onOff":1}}' of device 'undefined' (0x00124b0018df46f2)
  zigbee2mqtt:debug 2019-1-28 11:56:48 Ignoring message from coordinator
2019-01-28T01:56:51.436Z zigbee-shepherd:af dispatchIncomingMsg(): type: incomingMsg, msg: [object Object]
2019-01-28T01:56:51.450Z zigbee-shepherd:msgHdlr IND <-- AF:incomingMsg, transId: 0
2019-01-28T01:56:51.451Z zigbee-shepherd:af dispatchIncomingMsg(): type: zclIncomingMsg, msg: [object Object]
  zigbee2mqtt:debug 2019-1-28 11:56:51 Received zigbee message of type 'attReport' with data '{"cid":"genOnOff","data":{"onOff":0}}' of device 'undefined' (0x00124b0018df46f2)
  zigbee2mqtt:debug 2019-1-28 11:56:51 Ignoring message from coordinator
2019-01-28T01:56:52.132Z zigbee-shepherd:af dispatchIncomingMsg(): type: incomingMsg, msg: [object Object]
2019-01-28T01:56:52.140Z zigbee-shepherd:msgHdlr IND <-- AF:incomingMsg, transId: 0
2019-01-28T01:56:52.142Z zigbee-shepherd:af dispatchIncomingMsg(): type: zclIncomingMsg, msg: [object Object]
  zigbee2mqtt:debug 2019-1-28 11:56:52 Received zigbee message of type 'attReport' with data '{"cid":"genOnOff","data":{"onOff":1}}' of device 'undefined' (0x00124b0018df46f2)
  zigbee2mqtt:debug 2019-1-28 11:56:52 Ignoring message from coordinator
2019-01-28T01:56:52.539Z zigbee-shepherd:af dispatchIncomingMsg(): type: incomingMsg, msg: [object Object]
2019-01-28T01:56:52.547Z zigbee-shepherd:msgHdlr IND <-- AF:incomingMsg, transId: 0
2019-01-28T01:56:52.549Z zigbee-shepherd:af dispatchIncomingMsg(): type: zclIncomingMsg, msg: [object Object]
  zigbee2mqtt:debug 2019-1-28 11:56:52 Received zigbee message of type 'attReport' with data '{"cid":"genOnOff","data":{"onOff":0}}' of device 'undefined' (0x00124b0018df46f2)
  zigbee2mqtt:debug 2019-1-28 11:56:52 Ignoring message from coordinator

Furthermore thank you for explaining the method re left/right labelling. As these switches are almost always mounted vertically (portrait style) in Australia, it would be great to change the "left/right" to "top/bottom", which allows for a "centre" or "middle" for the 3-gang, and might be less confusing dependant on which way the switch is mounted. However this I assume isn't supported via devicePublish.js? : const postfixes = ['left', 'right', 'center', 'bottom_left', 'bottom_right', 'top_left', 'top_right'];

Is this something that could be modified easily without too much work?

Very happy that the "top_left" etc are in there as the 4 gang scene switches (no actual relays/gangs) are set out like this. Hope to tackle them later. However looking through the deviceReceive.js I noticed that some of the buttons don't exist as they do in the publish file: const dontCacheProperties = ['action', 'button', 'button_left', 'button_right', 'click', 'forgotten', 'keyerror']; Not sure if this is intentional?

@ryanbeaton
Copy link

Thanks for all your work on this.

The button labeling can be confusing based on mounting style, especially the four button scene controller as, for example, top right will vary by mounting rotation. Might have to have notes in the devices section.

Been very tempted to buy some and help out but put off by the reviews that they emit a strange hum that can be heard from two metres away! What is your experience.

@highground88
Copy link
Contributor Author

Thanks Ryan. Personally I can't hear any humming - I don't have any in the bedroom yet but have 5 switches in the house so far, nothing noticeable. All seem relatively good considering the prices and alternatives. The app however is fairly average. Where are you located?

@ryanbeaton
Copy link

@highground88 I’m in PER

@highground88
Copy link
Contributor Author

highground88 commented Jan 29, 2019 via email

@highground88
Copy link
Contributor Author

Switch feedback! My only confusion is re the first 'state:', and whether 'fz.ignore_onoff_change' is needed or is causing issues. The state topic doesn't seem to reflect on whether left, right, both or none are on or off.

e.g:

{"state":"OFF","linkquality":65,"state_left":"ON","state_right":"ON"}

{"state":"ON","linkquality":65,"state_left":"ON","state_right":"ON"}

{"state":"ON","linkquality":65,"state_left":"OFF","state_right":"ON"}

{"state":"OFF","linkquality":65,"state_left":"OFF","state_right":"OFF"}

{"state":"OFF","linkquality":65,"state_left":"ON","state_right":"OFF"}

@highground88
Copy link
Contributor Author

Needs more work. Will open once confirmed all working.

@highground88 highground88 deleted the patch-1 branch February 20, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants