-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated SMSZB-120 & new converter for genBinaryInput #2993
Conversation
converters/fromZigbee.js
Outdated
result.out_of_service = (msg.data['outOfService']===1); | ||
} | ||
if (msg.data.hasOwnProperty('presentValue')) { | ||
result.present_value = (msg.data['presentValue']===1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is a bit abstract, what does it mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Koenkk Removed outOfService
& presentValue
Will you change the voltage converter for the smoke detector as well? |
@rindlerblabla Done, both for Smoke, Fire and Siren |
Fixes Koenkk/zigbee2mqtt#8457 |
@@ -14,7 +14,7 @@ module.exports = [ | |||
model: 'HLU2909K', | |||
vendor: 'Datek', | |||
description: 'APEX smart plug 16A', | |||
fromZigbee: [fz.on_off, fz.electrical_measurement, fz.metering, fz.temperature], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure, was this removed on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it doesn't support seMetering so no need to keep it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it doesn't support seMetering so no need to keep it there.
@Koenkk Became a lot in this PR, but this should be final (I did notice you fixed correct the last commit, thank you) |
Thanks again @TheStigh ! |
No description provided.