Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SMSZB-120 & new converter for genBinaryInput #2993

Merged
merged 10 commits into from
Sep 12, 2021
Merged

Updated SMSZB-120 & new converter for genBinaryInput #2993

merged 10 commits into from
Sep 12, 2021

Conversation

TheStigh
Copy link
Contributor

@TheStigh TheStigh commented Sep 4, 2021

No description provided.

result.out_of_service = (msg.data['outOfService']===1);
}
if (msg.data.hasOwnProperty('presentValue')) {
result.present_value = (msg.data['presentValue']===1);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is a bit abstract, what does it mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Koenkk Removed outOfService & presentValue

@rindlerblabla
Copy link
Contributor

Will you change the voltage converter for the smoke detector as well?

@TheStigh
Copy link
Contributor Author

@rindlerblabla Done, both for Smoke, Fire and Siren

@rindlerblabla
Copy link
Contributor

Fixes Koenkk/zigbee2mqtt#8457

@@ -14,7 +14,7 @@ module.exports = [
model: 'HLU2909K',
vendor: 'Datek',
description: 'APEX smart plug 16A',
fromZigbee: [fz.on_off, fz.electrical_measurement, fz.metering, fz.temperature],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, was this removed on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it doesn't support seMetering so no need to keep it there.

Copy link
Contributor Author

@TheStigh TheStigh Sep 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it doesn't support seMetering so no need to keep it there.

@TheStigh
Copy link
Contributor Author

@Koenkk Became a lot in this PR, but this should be final (I did notice you fixed correct the last commit, thank you)

@Koenkk
Copy link
Owner

Koenkk commented Sep 12, 2021

Thanks again @TheStigh !

@Koenkk Koenkk merged commit ed6d2b2 into Koenkk:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants