Expose cover running state #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Mar 11, 2022
lib/exposes.js
Outdated
| @@ -335,6 +335,12 @@ class Cover extends Base { | |||
| this.features.push(new Numeric('tilt', access.ALL).withValueMin(0).withValueMax(100).withDescription('Tilt of this cover')); | |||
| return this; | |||
| } | |||
|
|
|||
| withRunning() { | |||
There was a problem hiding this comment.
I'm sorry for not being clear, what I mean was adding this to exposes like exposes.binary('running', ea.STATE, true, false) (so not making it part of the feature list)
There was a problem hiding this comment.
In the first time I tried this (without making as part of the feature list), but can`t figure out how to check/find exposed binary in this place: https://github.com/Koenkk/zigbee2mqtt/blob/7a2ddf24d32006bc05283c5ceb681dc9871b0347/lib/extension/homeassistant.ts#L380-L427
Upd: done!
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round II.
Related PR: Koenkk/zigbee2mqtt#11789