Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xiaomi Covers position jumping on stop #4039

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

Drafteed
Copy link
Contributor

@Drafteed Drafteed commented Mar 24, 2022

When the stop command is sent, the currentPositionLiftPercentage of the closuresWindowCovering cluster sending the current position of the curtains.

The problem is that the default converter fz.cover_position_tilt inverses the value and sets incorrect position (xiaomi expect 'open' to be 100, 'closed' to be 0, instead Zigbee specs).

Before

1

After

2

@Drafteed Drafteed changed the title Fix Xiaomi Covers jumping on stop Fix Xiaomi Covers position jumping on stop Mar 24, 2022
@Koenkk
Copy link
Owner

Koenkk commented Mar 26, 2022

thanks!

@Koenkk Koenkk merged commit dc19775 into Koenkk:master Mar 26, 2022
@Drafteed Drafteed deleted the fix-xiaomi-cover-jumping branch August 21, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants