-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Arrival Sensor KMPCIL tagv1 #4241
Conversation
converters/fromZigbee.js
Outdated
@@ -5178,6 +5184,35 @@ const converters = { | |||
return {state: (msg.data['presentValue']==0) ? 'OFF' : 'ON'}; | |||
}, | |||
}, | |||
kmpcil_presence_binary_input: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move both this code and lib/kmpcil.js
into devices/kmpcil.js
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Koenkk,
I looked at the code. If I move the code from lib/kmpcil.js to devices/kmpcil.js, then from fromZigbee.js must include devices/kmpcil.js. Is that ok for you? I see the example with xiaomi is that Xiaomi has lib/xiaomi.js that is included in fromZigbee.js
Please let me know what do you think is correct.
Thank you
Iman
@Koenkk, Please ignore my last reply. I think I understand your suggestion now. I just moved all the codes into device/kmpcil.js and has checked it in |
Added one more comment, could you also make a pr for https://github.com/koenkk/zigbee2mqtt.io, then this can be merged. |
Thanks. I will add the comments. The timeout is not actually for the device. It is just if you have home with many repeater made with very resources limited MCU, I want to make sure those repeater does not get overwhelmed with the configuration. If we have perfect repeater, I don't think we need the timeout. I will look at the zigbee2mqtt.io and make pr for that as well |
@Koenkk, I just looked at https://github.com/koenkk/zigbee2mqtt.io. I know that I need to add documentation for my device. May I have your guidance where should I add the documentation. There are many files in the source tree. |
Two files need to be added:
|
Thank you for the information. I will work on the documentation. |
Hi @Koenkk, In other device, there is a note in the documentation like below. My questions for you is that do I need just to filled the information in the note section and check in the file? title: "KMPCIL KMPCIL_RES005 control via MQTT"
|
Just filling the note section is enough, the rest will be generated automatically with the next z2m release. |
I am just curious whether there are any further changes needed for this PR. |
Forgot to merge, thanks for pining me! |
Thank you |
@Koenkk, here is the converter for Arrival Sensor. This request should have all the lint errors cleaned up.