Cloud Even Thermostatic Radiator Valve #4844
Conversation
|
Can this be merged with one of the already supported TuYa thermostats? (e.g. zigbee-herdsman-converters/devices/tuya.js Line 2019 in a197538 |
|
The closest match would be this: zigbee-herdsman-converters/devices/tuya.js Line 2195 in a197538 Even the actual hardware looks like the same as the HT-10 but some data points are different (localTemp, heatingSetpoint, errorStatus) and some of them are not implemented in etop_thermostat (ex: temp calibration): I would like to implement all of the features the TRV has. There are some datapoints that I still have to reverse engineer. |
|
Then lets keep it separate, can you refactor the code to use the new format? This reduces code size and makes it better maintainable. You can use this TuYa thermostat as an example: zigbee-herdsman-converters/devices/tuya.js Line 2098 in 17eef48 |
|
I've done the refactoring. Is the scheduling setup ok for you? |
|
@kovvik could we use the same schedule expose as zigbee-herdsman-converters/devices/tuya.js Line 2144 in ee138a3 The way it works is the in the frontend -> device -> exposes there is one schedule field where you can set the schedule for all the days. Would be even greater if we could also re-use zigbee-herdsman-converters/devices/tuya.js Line 2186 in ee138a3 |
|
Yes, I checked that. That assumes that there is a dedicated dp that I can send a schedule for any day (dp 100 for the TV02). But this TRV has no such dp, all schedules should be sent to its own data point (101-107). |
|
I've merged this into
|
lib/tuya.js
Outdated
| @@ -1244,6 +1249,7 @@ const valueConverterBasic = { | |||
| const valueConverter = { | |||
| trueFalse: valueConverterBasic.lookup({1: true, 0: false}), | |||
| onOff: valueConverterBasic.lookup({'ON': true, 'OFF': false}), | |||
| systemMode: valueConverterBasic.lookup({'heat': false, 'off': true}), | |||
There was a problem hiding this comment.
The values are the opposite here, sorry it was my mistake in the original file
| systemMode: valueConverterBasic.lookup({'heat': false, 'off': true}), | |
| systemMode: valueConverterBasic.lookup({'heat': true, 'off': false}), |
lib/tuya.js
Outdated
| @@ -1165,6 +1165,11 @@ const tuyaExposes = { | |||
| .withDescription('Result of the self-test'), | |||
| faultAlarm: () => exposes.binary('fault_alarm', ea.STATE, true, false).withDescription('Indicates whether a fault was detected'), | |||
| silence: () => exposes.binary('silence', ea.STATE_SET, true, false).withDescription('Silence the alarm'), | |||
| frostProtection: () => exposes.binary('frost_protection', ea.STATE_SET, 'ON', 'OFF').withDescription('When Anti-Freezing function'+ | |||
| ' is activated, the temperature in the house is kept at 8 °C, the device display "AF". Press the pair button to cancel.'), | |||
There was a problem hiding this comment.
The CloudEven TRV has no frost protection indication on its display. It can be checked and set in the service menu of the device.
| ' is activated, the temperature in the house is kept at 8 °C, the device display "AF". Press the pair button to cancel.'), | |
| ' is activated, the temperature in the house is kept at 8 °C.'), |
|
Fixed the issues, thanks! |
* Cloud Even Thermostatic Radiator Valve * CloudEven _TZE200_0hg58wyk trv * Update tuya.js * Update tuya.js * Update tuya.js * Delete cloudeven.js * Update index.test.js * Update tuya.js * Update tuya.js Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
add support for Cloud Even TRV