Handle hvacFanCtrl messages without fanMode data
#5327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles `hvacFanCtrl` messages where `fanMode` isn't present, such
as `{"fanModeSequence":1}` (such as that generated by the Mercator
SSWF01G fan controller, reported in
Koenkk/zigbee2mqtt#15186). Previously, without
`fanMode` present, the state was assumed to be on.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles
hvacFanCtrlmessages wherefanModeisn't present, such as{"fanModeSequence":1}(such as that generated by the Mercator SSWF01G fan controller, reported in Koenkk/zigbee2mqtt#15186). Previously, withoutfanModepresent in the message, the state was assumed to be on given the lookup implementation.Section 6.4.2.2 of the ZCL mentions that
FanModeandFanModeSequenceshould be mandatory but at least the SSWF01G sends these attributes in separate messages.