Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color handling for LIDL light bar (Koenkk/zigbee2mqtt#13421) #5514

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

AndreKR
Copy link
Contributor

@AndreKR AndreKR commented Feb 23, 2023

No description provided.

@Koenkk Koenkk merged commit 985fe1e into Koenkk:master Feb 23, 2023
@Koenkk
Copy link
Owner

Koenkk commented Feb 23, 2023

Made some small changes, many thanks!

I'm sure many people will be thankful!

@RubenKelevra
Copy link

Hey @Koenkk,

I think this has to be changed for the LIDL HG08010 (Livarno Home outdoor spotlight) as well, as 0 does something which looks like 1 second on them.

// A transition time of 0 would be treated as about 1 second, probably some kind of fallback/default
// transition time, so for "no transition" we use 1 (tenth of a second).

@RubenKelevra
Copy link

Hey @AndreKR, can you please explain how the color handling looks like before the fix? I like to confirm that it isn't happening on my HG08010 lamps :)

@AndreKR
Copy link
Contributor Author

AndreKR commented Mar 2, 2023

@RubenKelevra The light acts as a standard Zigbee light, but only in white mode. The RGB LEDs are controlled completely separate by custom commands that we added with this PR. If you try using the light as a normal Zigbee light without custom commands, if I remember correctly the color LEDs would turn on, but they didn't turn off, so you'd have color and white LEDs on at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants