Support Lidl / Parkside watering timer #5710
Conversation
|
Ah linting fails against the merged state. Seems that utils was removed in the mean time. I'll fix this. |
devices/lidl.js
Outdated
| @@ -140,6 +141,96 @@ const fzLocal = { | |||
| } | |||
| }, | |||
| }, | |||
| watering_time_left: { | |||
There was a problem hiding this comment.
Could you refactor this to a valueconverter? (such that we only use tuya.tz.datapoints for this device)
There was a problem hiding this comment.
Technically this should be possible, because this relies only on the ON/OFF DP and the current/previous state.
But then I need to replace the continues reporting of the remaining time by a JS interval. Is it possible to report state changes programmatically?
The current approach uses the continuous reporting of the battery level (every minute) to update the remaining time. But if there is way to do it programmatically, I can refactor this.
What I mean is something like that
var timer;
function valudeContverter() {
if (ON) {
timer = setInterval(() => {
// report state programmatically --> how?
device.updateState({time_left: xxx});
}, 1000 * 60);
} else {
clearInterval(timer);
timer = undefined;
}
}There was a problem hiding this comment.
I found a publish method, which is used in another converter to publish the state programmatically. This should work here too, if we pass it down to the DP.from converter.
@Koenkk does it makes sense this way?
There was a problem hiding this comment.
@zinserjan yes, feel free to pass the publish method
devices/lidl.js
Outdated
| [1, null, valueConverterLocal.wateringState], | ||
| // disable optimistic state reporting (device may not turn on when battery is low) | ||
| [1, 'state', tuya.valueConverter.onOff, {optimistic: false}], | ||
| [5, 'timer', tuya.valueConverter.range(1, 599)], |
There was a problem hiding this comment.
The range is already specified in the exposes, therefore there is no need to do it again here. I suggest to use tuya.valueConverter.raw here and remove tuya.valueConverter.range
There was a problem hiding this comment.
Yeah, I used this before but I noticed there isn't any validation. At least I was able to set unsupported values via frontend and MQTT messages. But that's a different story.
devices/lidl.js
Outdated
| toZigbee: [ | ||
| { | ||
| ...tuya.tz.datapoints, | ||
| key: ['state', 'timer', 'reset_frost_lock', 'schedule_periodic', 'schedule_weekday', |
There was a problem hiding this comment.
Please add these keys directly to tuya.tz.datapoints, this line should just be toZigbee: [tuya.tz.datapoints]
|
Many thanks! |
|
Wow this looks great, can't wait to get this in the next release and test it out. Many thanks!!! |
This adds full support for the lidl watering timer as requested in Koenkk/zigbee2mqtt#7695. Tuya dp converter format is used when possible.
Tested locally with npm link against the latest zigbee2mqtt:
Open tasks (won't fix):
This it how it looks like:
Btw while testing I discovered that the initial reporting of the device was unreliable in my production setup, but worked pretty good in my new dev setup. In my previous converter I got around this with a delay of one second before sending the tuya magic, but this doesn't help always.
The only real difference in my setup between dev and production was the used firmware. Since I updated the firmware in my production environment as well, the initial reporting seems to be working pretty solid, too.
Info: data restrictions by the original gateway
Note: Device may accepts higher values or invalid for some of these, but the following are the officially used ones.