Fix unknown power source for WSP403 #5750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
May 14, 2023
devices/owon.js
Outdated
| @@ -121,6 +122,11 @@ module.exports = [ | |||
| await reporting.instantaneousDemand(endpoint, {min: 5, max: constants.repInterval.MINUTES_5, change: 2}); // divider 1000: 2W | |||
| await reporting.currentSummDelivered(endpoint, {min: 5, max: constants.repInterval.MINUTES_5, | |||
| change: [10, 10]}); // divider 1000: 0,01kWh | |||
|
|
|||
| if (device.powerSource === 'Unknown') { | |||
| device.powerSource = 'Mains (single phase)'; | |||
There was a problem hiding this comment.
No need for this if check, for a power plug we can assume it is always main powered.
There was a problem hiding this comment.
I have just pushed a new commit that removes the check
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Oz Smart Things whitelabel of WSP403 reports an unknown power source. The WSP403 is a smart plug that is always connected to mains so this PR adds a check for that, as well as adding a
whiteLabelentry for good measure.