Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added valve opening and closing configuration for Sonoff TRVZB, v1.1.4 only #7130

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Added valve opening and closing configuration for Sonoff TRVZB, v1.1.4 only #7130

merged 4 commits into from
Apr 18, 2024

Conversation

lcheng33775823
Copy link
Contributor

No description provided.

Koenkk
Koenkk reviewed Feb 29, 2024
View reviewed changes
src/devices/sonoff.ts Outdated
unit: '%',
}),
numeric({
name: 'valve_closing_degree(version >= v1.1.4)',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move (version >= v1.1.4) to the description (same for valve_opening_degree)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reminding, it has been modified

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of which component does this refer to exactly?

@photomoose photomoose mentioned this pull request Mar 1, 2024
Closed
@jamesonuk jamesonuk mentioned this pull request Mar 6, 2024
Closed
@PrenommeNomme
Copy link

Hello,

Do you think that the possibility of controlling the opening of the valve in percentage could be integrated into 1.1.5 version?

Thank you

@jamesonuk
Copy link
Contributor

Just to say that I have just tried to apply this locally and I have the error

2024-04-08 17:29:36Publish 'get' 'valve opening' to 'Study TRV' failed: 'Error: Cluster with name '64529' does not exist'

which I think has been noted a few times in the 1.36.1 release thread so I don't think it is anything to do with this change but it is not working

@PrenommeNomme
Copy link

I thank you for your response and apologize for my messages which may be very approximate, as they are in automatic translation. I would like to be sure of your answer, if I have interpreted it correctly, you are explaining to me that whatever the future or past version it will not work with this thermostatic valve. I want to make sure, because I bought 8 of these thermostatic valves and I only have a short time to ask for a refund. If I am not mistaken about all of this, would you be kind enough to recommend one or more brands and models of thermostatic valves with which a maximum of read and write attributes are supported to control them, and especially the attribute to control the opening and closing of the thermostatic valve in degrees? Thank you so much.

@jamesonuk
Copy link
Contributor

I have had these working great with 1.1.1 firmware and 1.36 Zigbee2MQTT. There is an issuewith the very latest release (is not affecting their actual usage) but I think it will be fixed quite quickly.

I have had eight working fine for a few months

@PrenommeNomme
Copy link

Thank you. I myself find these thermostatic valves very good in terms of hardware and software and would like to focus on the Sonoff brand because its product range seems very developed, what do you think? But, it is essential for me the possibility of controlling the opening and closing of the thermostatic valve in percentage, because I want to use dedicated temperature sensors, and the "versatile_thermostat" plug-in in Home Assistant, what do you think?

@jamesonuk
Copy link
Contributor

Thank you. I myself find these thermostatic valves very good in terms of hardware and software and would like to focus on the Sonoff brand because its product range seems very developed, what do you think? But, it is essential for me the possibility of controlling the opening and closing of the thermostatic valve in percentage, because I want to use dedicated temperature sensors, and the "versatile_thermostat" plug-in in Home Assistant, what do you think?

This is a discussion for a new feature to be added to Zigbee2MQTT so not really the right place for this discussion. I am using the Better Thermostat integration with there valves and external temperature sensors and they work well. If you want to discuss further I suggest creating a new discussion on the Zigbee2MQTT project

https://github.com/Koenkk/zigbee2mqtt/discussions

@PrenommeNomme
Copy link

Ok. Thank you very much.

@PrenommeNomme
Copy link

PrenommeNomme commented Apr 18, 2024 via email

@Koenkk Koenkk merged commit 87601c2 into Koenkk:master Apr 18, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Apr 18, 2024

Thanks!

@Koenkk Koenkk mentioned this pull request Apr 17, 2024
Merged
@fir3drag0n
Copy link

fir3drag0n commented Apr 24, 2024 •
edited

I am getting errors if I want to set the valve position:

Info 2024-04-24 10:23:30Configuring 'TRV-Küche'
Error 2024-04-24 10:23:30Publish 'set' 'valve_opening_degree' to 'TRV-Küche' failed: 'Error: ZCL command 0x0cae5ffffeb0dc77/1 sonoffTrvzbCluster.write({"valveOpeningDegree":50}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'
Error 2024-04-24 10:23:32Exception while calling fromZigbee converter: Value is not a number, got undefined (undefined)}
Error 2024-04-24 10:23:32Failed to configure 'TRV-Küche', attempt 2 (Error: ZCL command 0x0cae5ffffeb0dc77/1 sonoffTrvzbCluster.read([0,24576,24578,24579,24580,24581,24582,24583], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE') at Endpoint.checkStatus (/app/node_modules/zigbee-herdsman/src/controller/model/endpoint.ts:314:28) at Endpoint.zclCommand (/app/node_modules/zigbee-herdsman/src/controller/model/endpoint.ts:769:26) at processTicksAndRejections (node:internal/process/task_queues:95:5) at Endpoint.read (/app/node_modules/zigbee-herdsman/src/controller/model/endpoint.ts:400:29) at configure (/app/node_modules/zigbee-herdsman-converters/src/devices/sonoff.ts:911:13) at Object.configure (/app/node_modules/zigbee-herdsman-converters/src/index.ts:160:21) at Configure.configure (/app/lib/extension/configure.ts:121:13) at EventEmitter.wrappedCallback (/app/lib/eventBus.ts:174:17))
Info 2024-04-24 10:23:43Configuring 'TRV-Küche'
Error 2024-04-24 10:23:43Publish 'set' 'valve_opening_degree' to 'TRV-Küche' failed: 'Error: ZCL command 0x0cae5ffffeb0dc77/1 sonoffTrvzbCluster.write({"valveOpeningDegree":55}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'
Error 2024-04-24 10:23:44Received undefined command from '0'
Error 2024-04-24 10:23:45Exception while calling fromZigbee converter: Value is not a number, got undefined (undefined)}
Error 2024-04-24 10:23:45Failed to configure 'TRV-Küche', attempt 3 (Error: ZCL command 0x0cae5ffffeb0dc77/1 sonoffTrvzbCluster.read([0,24576,24578,24579,24580,24581,24582,24583], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE') at Endpoint.checkStatus (/app/node_modules/zigbee-herdsman/src/controller/model/endpoint.ts:314:28) at Endpoint.zclCommand (/app/node_modules/zigbee-herdsman/src/controller/model/endpoint.ts:769:26) at processTicksAndRejections (node:internal/process/task_queues:95:5) at Endpoint.read (/app/node_modules/zigbee-herdsman/src/controller/model/endpoint.ts:400:29) at configure (/app/node_modules/zigbee-herdsman-converters/src/devices/sonoff.ts:911:13) at Object.configure (/app/node_modules/zigbee-herdsman-converters/src/index.ts:160:21) at Configure.configure (/app/lib/extension/configure.ts:121:13) at EventEmitter.wrappedCallback (/app/lib/eventBus.ts:174:17))
Error 2024-04-24 10:23:56Exception while calling fromZigbee converter: Value is not a number, got undefined (undefined)}
Error 2024-04-24 10:23:56Publish 'get' 'valve_opening_degree' to 'TRV-Küche' failed: 'Error: ZCL command 0x0cae5ffffeb0dc77/1 sonoffTrvzbCluster.read(["valveOpeningDegree"], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'
Error 2024-04-24 10:24:07Publish 'set' 'frost_protection_temperature' to 'TRV-Küche' failed: 'Error: ZCL command 0x0cae5ffffeb0dc77/1 sonoffTrvzbCluster.write({"frostProtectionTemperature":750}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'
Error 2024-04-24 10:24:10Publish 'set' 'frost_protection_temperature' to 'TRV-Küche' failed: 'Error: ZCL command 0x0cae5ffffeb0dc77/1 sonoffTrvzbCluster.write({"frostProtectionTemperature":700}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'
Error 2024-04-24 10:24:33Publish 'set' 'valve_opening_degree' to 'TRV-Küche' failed: 'Error: ZCL command 0x0cae5ffffeb0dc77/1 sonoffTrvzbCluster.write({"valveOpeningDegree":50}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'
Error 2024-04-24 10:25:01Publish 'set' 'valve_opening_degree' to 'TRV-Küche' failed: 'Error: ZCL command 0x0cae5ffffeb0dc77/1 sonoffTrvzbCluster.write({"valveOpeningDegree":45}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'
Error 2024-04-24 10:26:29Publish 'set' 'valve_opening_degree' to 'TRV-Küche' failed: 'Error: ZCL command 0x0cae5ffffeb0dc77/1 sonoffTrvzbCluster.write({"valveOpeningDegree":50}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'
Error 2024-04-24 10:27:04Received undefined command from '0'

I am at dev branch (docker).

@fir3drag0n fir3drag0n mentioned this pull request Apr 24, 2024
Closed
@blacknell blacknell mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhet dhet dhet left review comments

@Koenkk Koenkk Koenkk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lcheng33775823 @PrenommeNomme @jamesonuk @Koenkk @fir3drag0n @dhet