Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[high-conflict] Update manufacturer codes to use ZCL definition #7223

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Nerivec
Copy link
Contributor

@Nerivec Nerivec commented Mar 15, 2024

AKA less magic numbers 馃槈

Remains these, which apparently are not officially assigned to them:

    LIVOLO: 0x1AD2,
    LYTKO: 0x7777,
    PERENIO: 0x007B,

Like SPRUT I suppose they will have to be added as "custom" in herdsman before being changed here. Might I suggest using the CUSTOM_ prefix, just to be clear and avoid any potential conflict on future ZCL def changes?

@Koenkk
Copy link
Owner

Koenkk commented Mar 15, 2024

Might I suggest using the CUSTOM_ prefix, just to be clear and avoid any potential conflict on future ZCL def changes?

Yes please!

@Koenkk Koenkk merged commit ca21a1b into Koenkk:master Mar 15, 2024
2 checks passed
@Nerivec Nerivec deleted the use-zcl-def-manuf-codes branch March 15, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants