Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move led control to firmware #442

Merged
merged 1 commit into from Nov 14, 2021
Merged

Move led control to firmware #442

merged 1 commit into from Nov 14, 2021

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Oct 29, 2021

As discussed in Koenkk/Z-Stack-firmware#203 (comment) the LED control responsibility should move to the firmware. With the current implementation herdsman sets the LED on/off when joining is enabled, this breaks LEDs for custom firmwares.

With this change setLED() and supportsLED() are removed from the controller, herdsman will no longer control the LEDs when joining is enabled/disabled.

For ZStack adapters:

  • For firmwares having revision >= 20211029:

    • ledControl will not be called when joining is enabled/disabled
    • If disable_led: true is set LED control is called with {ledid: 0xFF, mode: 5}. When ledControl is called with mode: 5 the firmware should disable all leds.
  • For firmwares having revision < 20211029, the behaviour isn't changed ledControl is still called when joining is enabled/disabled. (this is to avoid a breaking change on firmwares not turning on leds when joining is enbaled/disabled)

  • I will provide new firmwares which have internal LED control when joinig is enabled/disabled:

  • For Zigbee2MQTT this requires: Dont control leds zigbee2mqtt#9404

Please review: @egony @kirovilya

@egony
Copy link

egony commented Nov 1, 2021

Hi!
Description looks reasonable, I think all is right...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants