Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Koenkk/Z-Stack-firmware#203 (comment) the LED control responsibility should move to the firmware. With the current implementation herdsman sets the LED on/off when joining is enabled, this breaks LEDs for custom firmwares.
With this change
setLED()
andsupportsLED()
are removed from the controller, herdsman will no longer control the LEDs when joining is enabled/disabled.For ZStack adapters:
For firmwares having
revision >= 20211029
:ledControl
will not be called when joining is enabled/disableddisable_led: true
is set LED control is called with{ledid: 0xFF, mode: 5}
. WhenledControl
is called withmode: 5
the firmware should disable all leds.For firmwares having
revision < 20211029
, the behaviour isn't changedledControl
is still called when joining is enabled/disabled. (this is to avoid a breaking change on firmwares not turning on leds when joining is enbaled/disabled)I will provide new firmwares which have internal LED control when joinig is enabled/disabled:
For Zigbee2MQTT this requires: Dont control leds zigbee2mqtt#9404
Please review: @egony @kirovilya