add mdns discovery for network coordinators #704

Tarik2142 · 2023-04-30T20:36:53Z

I described everything in the request here #Koenkk/zigbee2mqtt#17430
I don't know much about typescript so improvements are welcome

rev 1 1 adapter support

Koenkk · 2023-05-01T16:48:28Z

Thanks for the PR, in order to get this merged:

Make sure to add tests for this (npm run test-with-coverage should pass)
Create a PR to update the docs (https://github.com/koenkk/zigbee2mqtt.io/)

Tarik2142 · 2023-05-01T17:32:54Z

Thanks for the PR, in order to get this merged:

Make sure to add tests for this (npm run test-with-coverage should pass)

Create a PR to update the docs (https://github.com/koenkk/zigbee2mqtt.io/)

Ok, thanks for the reply. I think there will be no problems with the documentation, but I've never written tests, so I'll have to figure it out.
I ran a local check and somehow it passes. Here on github everything correctly shows that there are no tests for lines 85-115
I would be grateful for a hint why the local check is passing

Koenkk · 2023-05-02T17:06:43Z

Can you try to do a npm ci and then a npm run-test-with-coverage?

removed the timer in the detection function, improved messages in the log, added missing types

Tarik2142 · 2023-05-02T20:36:52Z

Can you try to do a npm ci and then a npm run-test-with-coverage?

Unfortunately that didn't help so I'll look here sometimes.
Also, I got a strange thing in the test system, when passing the LoggerStub to the Adapter, the logger for some reason still remains undefined and causes an error

-Adapter mdns without type test -Adapter mdns detection test -Minor improvements

Tarik2142 · 2023-05-03T19:18:18Z

why line 107 is uncovered?
do i need to check all radio types?

Tarik2142 · 2023-05-03T19:52:44Z

After the PR to the documentation, I will update the code and add a links to the documentation in the error messages

Koenkk · 2023-05-04T12:45:46Z

src/adapter/adapter.ts

+            const mdnsDevice = serialPortOptions.path.substring(7);
+            if(mdnsDevice.length == 0){
+                throw new Error(
+                    `You must specify the adapter type after mdns://`+


Do I understand correctly that the adapter type has to be specified in the serial.port? What about using the existing serial.adapter ?

This is a misunderstanding, I meant MDNS service type. This error text really needs to be edited.

The user needs to specify only the MDNS service type of the device, all other configuration data will be received from the device via Zeroconf

Potentially, all Zeroconf devices listed here should work except tube
tube uses the esphomelib type, that is, if there are other esphome devices on the network, they will probably be found instead of the coordinator

I see, this means that the config from the z2m configuration.yaml is ignored?

True, some parameters from the config will be ignored because they will be received from the coordinator

I see, this should be clearly stated in the docs, could you make a pr for the docs? (https://www.zigbee2mqtt.io/guide/configuration/adapter-settings.html)

yes, I'm currently working on PR for docs

Tarik2142 · 2023-05-04T20:10:20Z

So the links exceed the length limit, how should I shorten them?

Tarik2142 · 2023-05-05T13:37:25Z

@Koenkk
PR to docs is ready Koenkk/zigbee2mqtt.io#2028

Koenkk · 2023-05-06T11:00:29Z

@Tarik2142 I made some updates, can you check if everything is still ok? If yes, I will merge this.

Tarik2142 · 2023-05-06T11:40:48Z

@Koenkk
Tested the changes on my installation.

Everything works.

Also tested handling of some errors, except the wrong packet, this requires changing the firmware of the coordinator

Koenkk · 2023-05-06T13:37:16Z

Great, thanks for this cool feature!

stefa168 · 2023-06-01T11:26:10Z

@Tarik2142 sorry for the ping; what functionalities this PR would bring to a user? I am just curious about it 👀

Tarik2142 · 2023-06-01T11:42:55Z

@Tarik2142 sorry for the ping; what functionalities this PR would bring to a user? I am just curious about it 👀

https://www.zigbee2mqtt.io/guide/configuration/adapter-settings.html#mdns-zeroconf-discovery
If your coordinator supports this functionality, you can type mdns name in the configuration, IP, port and adapter type will be determined automatically. Even if the IP of the adapter changes, it will still be found. This simplifies the configuration

Tarik2142 added 2 commits April 30, 2023 23:28

mdns discovery

f45272b

rev 1 1 adapter support

Merge branch 'Koenkk:master' into master

0a12860

code optimization, first test

fcacec6

removed the timer in the detection function, improved messages in the log, added missing types

Tarik2142 added 3 commits May 3, 2023 22:01

add tests

98e3190

-Adapter mdns without type test -Adapter mdns detection test -Minor improvements

add wrong Zeroconf test

ef45945

add mdns detection ezsp test

7274a63

Tarik2142 added 2 commits May 3, 2023 22:42

lint fixes

581e7c2

lint fixes

3b1a94a

Koenkk reviewed May 4, 2023

View reviewed changes

Improved log text

73a4012

Tarik2142 mentioned this pull request May 4, 2023

Update adapter-settings, add ZB-OTA info Koenkk/zigbee2mqtt.io#2028

Merged

lint fix

3888924

Koenkk added 3 commits May 6, 2023 12:52

Update adapter.ts

fcf3b80

Merge branch 'master' into master

4b08d76

Updates

7ec1c0c

Koenkk merged commit 08e0aa1 into Koenkk:master May 6, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add mdns discovery for network coordinators #704

add mdns discovery for network coordinators #704

Tarik2142 commented Apr 30, 2023

Koenkk commented May 1, 2023

Tarik2142 commented May 1, 2023

Koenkk commented May 2, 2023

Tarik2142 commented May 2, 2023

Tarik2142 commented May 3, 2023 •

edited

Tarik2142 commented May 3, 2023

Koenkk May 4, 2023

Tarik2142 May 4, 2023

Koenkk May 4, 2023

Tarik2142 May 4, 2023

Koenkk May 4, 2023

Tarik2142 May 4, 2023

Tarik2142 commented May 4, 2023

Tarik2142 commented May 5, 2023

Koenkk commented May 6, 2023

Tarik2142 commented May 6, 2023 •

edited

Koenkk commented May 6, 2023

stefa168 commented Jun 1, 2023

Tarik2142 commented Jun 1, 2023 •

edited

add mdns discovery for network coordinators #704

add mdns discovery for network coordinators #704

Conversation

Tarik2142 commented Apr 30, 2023

Koenkk commented May 1, 2023

Tarik2142 commented May 1, 2023

Koenkk commented May 2, 2023

Tarik2142 commented May 2, 2023

Tarik2142 commented May 3, 2023 • edited

Tarik2142 commented May 3, 2023

Koenkk May 4, 2023

Choose a reason for hiding this comment

Tarik2142 May 4, 2023

Choose a reason for hiding this comment

Koenkk May 4, 2023

Choose a reason for hiding this comment

Tarik2142 May 4, 2023

Choose a reason for hiding this comment

Koenkk May 4, 2023

Choose a reason for hiding this comment

Tarik2142 May 4, 2023

Choose a reason for hiding this comment

Tarik2142 commented May 4, 2023

Tarik2142 commented May 5, 2023

Koenkk commented May 6, 2023

Tarik2142 commented May 6, 2023 • edited

Koenkk commented May 6, 2023

stefa168 commented Jun 1, 2023

Tarik2142 commented Jun 1, 2023 • edited

Tarik2142 commented May 3, 2023 •

edited

Tarik2142 commented May 6, 2023 •

edited

Tarik2142 commented Jun 1, 2023 •

edited