fix: Fix crash due to unhandled Promise exception #20473

Koenkk · Jan 3, 2024 · e6bcf91 · e6bcf91
1 parent 7e37365
commit e6bcf91
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/lib/eventBus.ts b/lib/eventBus.ts
@@ -161,10 +161,14 @@ export default class EventBus {
         this.on('stateChange', callback, key);
     }
 
-    private on(event: string, callback: (...args: unknown[]) => void, key: ListenerKey): void {
+    private on(event: string, callback: (...args: unknown[]) => (Promise<void> | void), key: ListenerKey): void {
         if (!this.callbacksByExtension[key.constructor.name]) this.callbacksByExtension[key.constructor.name] = [];
-        this.callbacksByExtension[key.constructor.name].push({event, callback});
-        this.emitter.on(event, callback);
+        const wrappedCallback = (...args: unknown[]): void => {
+            // Wrap callback as it may return a Promise which can throw an exception
+            Promise.resolve(callback(...args)).catch();
+        };
+        this.callbacksByExtension[key.constructor.name].push({event, callback: wrappedCallback});
+        this.emitter.on(event, wrappedCallback);
     }
 
     public removeListeners(key: ListenerKey): void {