Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log firmware version on startup #178

Closed
Koenkk opened this issue Jul 3, 2018 · 12 comments
Closed

Log firmware version on startup #178

Koenkk opened this issue Jul 3, 2018 · 12 comments
Labels
feature request Feature request stale Stale issues

Comments

@Koenkk
Copy link
Owner

Koenkk commented Jul 3, 2018

See @tb-killa comment from #174

@Koenkk Koenkk added the feature request Feature request label Jul 3, 2018
@Koenkk Koenkk added this to the 0.2 milestone Jul 3, 2018
@tb-killa
Copy link
Contributor

tb-killa commented Jul 3, 2018

@Koenkk Could we extend our welcome Message:

2018-7-3 22:44:38 �[32mINFO�[39m Starting zigbee2mqtt version 0.1.0 (commit #ae41b7b)
2018-7-3 22:44:38 �[32mINFO�[39m Starting zigbee-shepherd
2018-7-3 22:44:40 �[32mINFO�[39m zigbee-shepherd started

with

zigbee-shepherd started with loaded configuration:

and the Informations from
lib/shepherd.js with function ZShepherd.prototype.info
???

@Koenkk
Copy link
Owner Author

Koenkk commented Jul 4, 2018

@tb-killa yes!

@tb-killa
Copy link
Contributor

tb-killa commented Jul 5, 2018

@Koenkk Nice :)

2018-7-5 20:19:54 INFO zigbee-shepherd started
2018-7-5 20:19:54 DEBUG zigbee-shepherd info: {"enabled":true,"net":{"state":"Coordinator","channel":11,"panId":"0x1a62","extPanId":"0xdddddddddddddddd","ieeeAddr":"0x00124b000e896656","nwkAddr":0},"firmware":{"error":"Unable to get firmware version"},"startTime":1530814794,"joinTimeLeft":0}
2018-7-5 20:19:54 INFO Currently 3 devices are joined:

Have to check the above mentioned Code for Firmware Version, it seems that i miss something :(

@Koenkk
Copy link
Owner Author

Koenkk commented Jul 5, 2018

@tb-killa yes, working on that now

Koenkk added a commit to Koenkk/Z-Stack-firmware that referenced this issue Jul 5, 2018
Koenkk added a commit to Koenkk/zigbee-shepherd that referenced this issue Jul 5, 2018
Koenkk added a commit to Koenkk/zigbee-shepherd that referenced this issue Jul 5, 2018
@Koenkk
Copy link
Owner Author

Koenkk commented Jul 5, 2018

Implemented, looks like:

2018-7-5 21:22:38 DEBUG zigbee-shepherd info: {"enabled":true,"net":{"state":"Coordinator","channel":11,"panId":"0x1a62","extPanId":"0xdddddddddddddddd","ieeeAddr":"0x00124b000e89686d","nwkAddr":0},"firmware":{"transportrev":2,"product":0,"version":"2.6.3","revision":20180507},"startTime":1530818558,"joinTimeLeft":0}

@ryanbeaton
Copy link

So only when logging level is debug then?

@tb-killa
Copy link
Contributor

tb-killa commented Jul 8, 2018

@ryanbeaton yes because normaly you need this Informations only if you would debug something what doesnt seems to work.

But maybe we cut this message and bring Version as normal output.?
@Koenkk what do you think?

@Koenkk Koenkk reopened this Jul 9, 2018
@Koenkk Koenkk removed this from the 0.2 milestone Jul 25, 2018
@tb-killa
Copy link
Contributor

@Koenkk We should cut the message output from ZShepherd.prototype.info

zigbee-shepherd info: {"enabled":true,"net":{"state":"Coordinator","channel":11,"panId":"0x1a62","extPanId":"0xdddddddddddddddd","ieeeAddr":"0x00124b000e896656","nwkAddr":0},"firmware":{"transportrev":2,"product":0,"version":"2.6.3","revision":20180507},"startTime":1534098600,"joinTimeLeft":0}

I don't think the following is needed:
"enabled":true, because we know if shepherd is running or not ;)
"state":"Coordinator" can we be anything but Coordinator ?
"transportrev":2,"product":0 we doesn´t need this
"startTime":1534098600 we know our startTime ;)
"joinTimeLeft":0 we doesn´t need this except we allow User to define own joinTime (maybe we should put this in?) ;)

@Koenkk
Copy link
Owner Author

Koenkk commented Aug 13, 2018

I think we can keep it like this. Note that the firmware version is now also logged separately as info.

  zigbee2mqtt:info 2018-8-13 19:12:16 Coordinator firmware version: '20180507'
  zigbee2mqtt:debug 2018-8-13 19:12:16 zigbee-shepherd info: {"enabled":true,"net":{"state":"Coordinator","channel":11,"panId":"0x1a62","extPanId":"0xdddddddddddddddd","ieeeAddr":"0x00124b000e89686d","nwkAddr":0},"firmware":{"transportrev":2,"product":0,"version":"2.6.3","revision":20180507},"startTime":1534180336,"joinTimeLeft":0}

@tb-killa
Copy link
Contributor

great .. doesn´t realice this information xD ..

@ryanbeaton
Copy link

Nice. Will definitely help support requests.

@stale
Copy link

stale bot commented Dec 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues label Dec 15, 2018
@stale stale bot closed this as completed Dec 22, 2018
qm3ster pushed a commit to zigbeer/zigbeer that referenced this issue Mar 11, 2019
qm3ster pushed a commit to zigbeer/zigbeer that referenced this issue Mar 11, 2019
wilmardo pushed a commit to wilmardo/zigbee2mqtt that referenced this issue Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request stale Stale issues
Projects
None yet
Development

No branches or pull requests

3 participants