Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Repair Backup" function of latest dev creates duplicate entries #18718

Closed
okastl opened this issue Aug 24, 2023 · 2 comments
Closed

"Repair Backup" function of latest dev creates duplicate entries #18718

okastl opened this issue Aug 24, 2023 · 2 comments
Labels
problem Something isn't working

Comments

@okastl
Copy link

okastl commented Aug 24, 2023

What happened?

When stopping z2m, herdsman complains about missing link keys (not true) and adds all devices twice to the backup.
Starting and stopping z2m again, and the backup grows larger and larger.

What did you expect to happen?

No duplicate entries.

How to reproduce it (minimal and precise)

Stop z2m.

Zigbee2MQTT version

1.32.2-dev commit: 6a1b6a1

Adapter firmware version

20230507

Adapter

Sonoff zStack3x0

Debug log

herdsman log:

  zigbee-herdsman:adapter:zStack:startup:backup fetched adapter network security material table (capacity=2, used=2) +106ms
  zigbee-herdsman:adapter:zStack:startup:backup Following devices with link key are missing from new backup but present in old backup and database, adding them back: 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x0004740000c60f8e, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x540f57fffe1671ad, 0x00158d0005a0bfd8, 0x000d6f000e11088c, 0xa4c13855b8ab6da7, 0x0004740000c60f8e +13ms

Attached is coordinator_backup.json and database.db from my test network.
data.zip

@okastl okastl added the problem Something isn't working label Aug 24, 2023
Koenkk added a commit to Koenkk/zigbee-herdsman that referenced this issue Aug 25, 2023
@Koenkk
Copy link
Owner

Koenkk commented Aug 25, 2023

Fixed, many thanks for noticing this! Let me know if all is OK now.

Changes will be available in the dev branch in a few hours from now. (https://www.zigbee2mqtt.io/advanced/more/switch-to-dev-branch.html)

@okastl
Copy link
Author

okastl commented Aug 25, 2023

Let me know if all is OK now.

Seems to be fine now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants