Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.0 dev - Network map weirdness #1961

Closed
james-fry opened this issue Sep 12, 2019 · 25 comments
Closed

1.6.0 dev - Network map weirdness #1961

james-fry opened this issue Sep 12, 2019 · 25 comments
Labels
problem Something isn't working

Comments

@james-fry
Copy link

Bug Report

What happened

Network map is rendering extremely strangely
image

I can provide logs of the network diagram log.

What did you expect to happen

Network map will look similar to how it looked on 1.5.1 (or better ;))

How to reproduce it (minimal and precise)

Unsure

Debug Info

zigbee2mqtt version:
hassio addon edge (1.6.0 dev)
CC253X firmware version:
CC2530_CC2591_SOURCE_ROUTING_20190619

@james-fry
Copy link
Author

Refreshed again and got this:

image

@Koenkk
Copy link
Owner

Koenkk commented Sep 12, 2019

Please provide logs.

@james-fry
Copy link
Author

james-fry commented Sep 12, 2019

Thanks for looking

https://pastebin.com/FxHRssLP

Diagram 1 @ 21:00
Diagram 2 @ 21:21

@clockbrain
Copy link
Contributor

In your first map at 21:00 the 'Ikea Router Kitchen' didn't respond to the link quality request (LQI).
In your second map at 21:21 both the 'Ikea Router Kitchen' and the 'Garden Floodlight' didn't respond.

This can be seen in the log file:

9/12/2019, 9:21:41 PM - info: Starting network scan (includeRoutes 'false')
9/12/2019, 9:21:41 PM - debug: LQI succeeded for 'Fireplace Lights'
9/12/2019, 9:21:51 PM - error: Failed to execute LQI for 'Ikea Router Kitchen'
9/12/2019, 9:21:51 PM - debug: LQI succeeded for 'CC2531 Router Kitchen'
9/12/2019, 9:21:51 PM - debug: LQI succeeded for 'Garden Switch'
9/12/2019, 9:22:01 PM - error: Failed to execute LQI for 'Garden Floodlight'
9/12/2019, 9:22:01 PM - debug: LQI succeeded for 'Ikea Tradfri WW Bulb'
9/12/2019, 9:22:01 PM - debug: LQI succeeded for 'Coordinator'
9/12/2019, 9:22:02 PM - debug: LQI succeeded for 'Kitchen Pendant'
9/12/2019, 9:22:02 PM - info: Network scan finished

and is also tagged (somewhat subtly) on the map itself:
image

I've no idea why those devices didn't respond - timeout/powered off/lost pairing? But that is where to start looking. Do they still respond to commands? Did the map repair itself later?

@james-fry
Copy link
Author

Thanks @clockbrain.
Def there some issues in my network but I more raised this defect because of the rendering issue where nodes in the graph are plotted in the far extremes

@Koenkk
Copy link
Owner

Koenkk commented Sep 13, 2019

@james-fry note that the rendering is not done by zigbee2mqtt.

@james-fry
Copy link
Author

@Koenkk this I understand, but it seems there is data from z2m that is driving these strange maps.
Its not impossible that a problem with my devices suddenly occurred and made this happen, but I think it is related to 1.6.0 upgrade. If this is not correct, please feel free to close the issue.

@dreimer1986
Copy link

dreimer1986 commented Sep 13, 2019

Some things clearly changed in that matter. See above the report I linked to. In the lovelace networkmap by azuwis there are zero links between the devices in 1.6.0 dev and the one by rgruebel looks quite funny on my side, too. Not that strange as the OP pics show, but some links are gone for sure. Both worked fine / looked different in 1.5.1:

rgruebel version (before all devices had links to almost any other routing supportive device resulting in a massive mesh):
2019-09-13 13_20_27-Home Assistant

azuwis version (before had at least links between each other):
2019-09-13 13_20_47-Home Assistant

Both no show stopper for me as 1.6.0 is more stable in pairing matters which is way more important for me, but just wanted to show my results.

log.zip

@Koenkk
Copy link
Owner

Koenkk commented Sep 15, 2019

@dreimer1986 did any of the scans fail? It may that the output has been changed.

@dreimer1986
Copy link

Not really. Scans worked on 1.5.1 and do on 1.6.0 as it seems. If you dont see any strange things in that log, I must say all is fine in device using matters.

@juanjux
Copy link

juanjux commented Sep 17, 2019

My network map is also broken in 1.6-dev. Most of the routers are missing (I've more than 50, they work otherwise) and there are no lines between the others. It worked on 1.5.1:

image

@dreimer1986
Copy link

After 11aacb8 I am out. rgruebel version still looks different to 1.5.1 but maybe this one is the correct one. At least it looks correct connection wise. And azuwis one is fine again too.
2019-09-18 08_36_14-Home Assistant
2019-09-18 08_40_39-Home Assistant

@Gesfenlir
Copy link

I have the same issue here...

  • (almost all) my router devices got a LQI and show up connected between each other on the map
  • none on the endpoint devices are connected to any router (on the map)
  • my Ikea Repeater does not show on the map at all (neither in the log)

Nothing special shows up in the log after I launch zigbee2mqtt_networkmap.update service.

Note that all works well, only the map has a weird rendering.

@lolorc
Copy link
Contributor

lolorc commented Oct 4, 2019

same here, just a few devices connected while it was ok before upgrading to 1.6-dev.
devices work ok as well.
Is anybody running 1.6-dev having a proper map (like it was with 1.5*) ?

@james-fry
Copy link
Author

james-fry commented Oct 31, 2019

I would be happy to close this issue now.
The network map has stabilised for me on 1.6 dev and I didnt see the really weird rendering from my 1st few posts in this issue.

This said I still have the issue with many/most end devices not showing a relationship to a router or the coordinator, and where there is often no bi-directional relationship between routers.

This is how its looking now.

image

BTW I have this problem with both of the following set ups:

  • cc2530, Z-Stack_Home_1.2 (source_routing)
  • cc1352P, Z-Stack_3.x.0

I'd really like to get to the bottom of this...

@lolorc
Copy link
Contributor

lolorc commented Oct 31, 2019

all my devices used to be connected to my coordinator/router, it's not anymore. I also think this is a bug needing a fix

@james-fry
Copy link
Author

@lolorc I dont disagree. Just not sure that this issue is the correct place.
Unfortunately I didnt have a good map before 1.6 dev either :( so for me this issue was more about the really weird rendering I saw with the very early 1.6 dev versions.

@Koenkk it seems really important to people to be able to reliably and accurately visualise their network (as evidenced by the 3+ map solutions out there). Do you prefer I close this issue and either @lolorc or me etc can create a new issue to get the missing info in the maps resolved? Or we continue to use this issue?

@lolorc
Copy link
Contributor

lolorc commented Oct 31, 2019

it might be related to Koenkk/zigbee-herdsman#69

@timota
Copy link

timota commented Oct 31, 2019

Probably i need to put this here, not sure

I made some tests to check:

  • if i add only 2 devices (end-devices) to coordinator - i can see linkquality for them and so z2mAssistant can build proper map.
  • if i add 3-d device:
    • in logs i can see that device reports linkquality
      zigbee2mqtt:info 2019-10-31T19:37:38: MQTT publish: topic 'zigbee2mqtt/0x00158d000274fe84', payload '{"battery":80,"voltage":2965,"contact":false,"linkquality":51,"last_seen":1572550658817,"device":{"friendlyName":"0x00158d000274fe84","ieeeAddr":"0x00158d000274fe84","networkAddress":17964,"type":"EndDevice","manufacturerID":4151,"manufacturerName":"LUMI","powerSource":"Battery","applicationVersion":3,"stackVersion":2,"zclVersion":1,"hardwareVersion":2,"dateCode":"20161128","softwareBuildID":"3000-0001"}}'

but in z2mAssistant reports all attributes except Link quality is unknown/255., so it cant build map

  • if i add to the same setup additional router, and after it add 3 additional end-devices. z2mAssistant reports linkquolity for first 2 devices (including router itself) but not for 3-d device.
  • same picture if i add another router and next 3 end-devices.

for me it looks like somewhere limit for 3 device (including router/coordinator) has been set.

i definitely didnt see this issue with Stable 1.6 and CC2531 as coordinator.

BTW: current coordinator is cc1352P2

@james-fry
Copy link
Author

I think this lines up with what I am seeing, @timota.
Also cc1352p-2, but not sure that matters.

E.g. below, where I have 2 x end devices on the coord, and 2 x end devices on the router.
The rest, nothing.

image

@Koenkk Koenkk added the problem Something isn't working label Nov 1, 2019
@Koenkk
Copy link
Owner

Koenkk commented Nov 10, 2019

Should be fixed in latest dev (should give same behaviour as 1.6.0). (reference #2307)

@axiom00
Copy link

axiom00 commented Nov 10, 2019

Latest dev fixed the mapping issue. Just have to figure out why nothing is using the repeaters.

image

@james-fry
Copy link
Author

Maybe the end devices can reach the coordinator directly OR via router.
Then we end up with maps like this (deconz):

image

I mentioned it in another thread, but I think the best solution is for some form of interactivity in the map to redraw the map in the context of a selected node.
Clearly this is much more development than what we have here...

@Koenkk
Copy link
Owner

Koenkk commented Nov 11, 2019

@james-fry this is out of scope for zigbee2mqtt and should be done by the application rendering the graph.

Closing as this issue has been fixed.

@Koenkk Koenkk closed this as completed Nov 11, 2019
@james-fry
Copy link
Author

Don’t disagree at at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants