Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Livarno Lux E27 bulb RGB UNSUPPORTED_ATTRIBUTE when try restore color on expose #6921

Closed
shirou93 opened this issue Apr 2, 2021 · 26 comments
Labels
problem Something isn't working

Comments

@shirou93
Copy link

shirou93 commented Apr 2, 2021

What happened

Screenshot_20210402-070643
When try restore color got this error:

(Propably this issue have all Lidl livarno bulbs)

Zigbee2MQTT:error 2021-04-02 07:02:30: Publish 'get' 'color' to 'Światło Pokój' failed: 'Error: Read 0x842e14fffe1b95c6/1 lightingColorCtrl(["currentX","currentY","enhancedCurrentHue","currentSaturation"], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'

What did you expect to happen

Restore color

How to reproduce it (minimal and precise)

Debug info

Zigbee2MQTT version: 1.18.2-1
Adapter hardware: CC2652RB
Adapter firmware version: CC2652RB_coordinator_20210120.zip

@shirou93 shirou93 added the problem Something isn't working label Apr 2, 2021
@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 2, 2021

Can you try using the read convertor to see if it is enhancedCurrentHue that is causing the issue, the bulb might only support the non enhanced version.

(Make sure to use your friendly_name)

mosquitto_pub -t zigbee2mqtt/0x14b457fffe2bd760/set/read -m '{"attributes": ["enhancedCurrentHue"], "cluster": "lightingColorCtrl"}'

It only logs to debug logging, so you need to enable that too, if that fails you can try reading the non enhanced variant.

mosquitto_pub -t zigbee2mqtt/0x14b457fffe2bd760/set/read -m '{"attributes": ["currentHue"], "cluster": "lightingColorCtrl"}'

@shirou93
Copy link
Author

shirou93 commented Apr 2, 2021

bash: mosquitto_pub: command not found - container in HomeAssistant

This is same MQTT: Publish in dev panel Home Assistant?

@nurikk
Copy link
Collaborator

nurikk commented Apr 3, 2021

Can you try using the read convertor to see if it is enhancedCurrentHue that is causing the issue, the bulb might only support the non enhanced version.

(Make sure to use your friendly_name)

mosquitto_pub -t zigbee2mqtt/0x14b457fffe2bd760/set/read -m '{"attributes": ["enhancedCurrentHue"], "cluster": "lightingColorCtrl"}'

It only logs to debug logging, so you need to enable that too, if that fails you can try reading the non enhanced variant.

mosquitto_pub -t zigbee2mqtt/0x14b457fffe2bd760/set/read -m '{"attributes": ["currentHue"], "cluster": "lightingColorCtrl"}'

hey guys, @sjorge @shirou93 I've implemented UI for this api, try to update on latest dev branch

@sjorge I would like to hear your feedback for future improvements

Screenshot 2021-04-03 at 15 42 05

@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 3, 2021

@nurikk seems to work well enough, I did notice a minor issue with the results not being cleared when doing a new read.
e.g. read genBasic.zlcVersion, then read OnOff.onOff both results are displayed below. Aside from that, it's very usable.

I'm not sure we should show this by default though, it was only ever intended to help us (us being developers) to get a way to have a user test something in a quick and easy way. cc: @Koenkk any opinion on this? Should this be hidden behind a configuration property? Or just have it show up for everyone?

@shirou93
Copy link
Author

shirou93 commented Apr 3, 2021

Hey guys, we getting off the point ... How do I use this tool to help fix the issue?

@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 3, 2021

Hey guys, we getting off the point ... How do I use this tool to help fix the issue?

If you can get on the latest dev release, you should now be able to use the frontend and try to reed this the attribute mentioned earlier.

image

Is what it looks like when it's not supported, which I suspect is the case for the Livarno.

If it is support it will look like this (other hue value most likely though)

image

@shirou93
Copy link
Author

shirou93 commented Apr 3, 2021

Hey guys, we getting off the point ... How do I use this tool to help fix the issue?

If you can get on the latest dev release, you should now be able to use the frontend and try to reed this the attribute mentioned earlier.

image

Is what it looks like when it's not supported, which I suspect is the case for the Livarno.

If it is support it will look like this (other hue value most likely though)

image

what exactly type on textbox attribute?

@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 3, 2021

what exactly type on textbox attribute?

It's actually a drop down, you select 'enhancedCurrentHue'

@shirou93
Copy link
Author

shirou93 commented Apr 3, 2021

what exactly type on textbox attribute?

It's actually a drop down, you select 'enhancedCurrentHue'

Screenshot_20210403-234209
No this option on list.

@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 3, 2021

Cluster => LColorCtrl
Attribute => enhancedCurrentHue

@shirou93
Copy link
Author

shirou93 commented Apr 3, 2021

Cluster => LColorCtrl
Attribute => enhancedCurrentHue

Thx.
Screenshot_20210403-234605

sjorge added a commit to sjorge/zigbee-herdsman-converters that referenced this issue Apr 3, 2021
As discovered in Koenkk/zigbee2mqtt#6921 these bulbs do not support enhancedHue.

- [x] Update the saveClusterAttributeKeyValue (Wy are we even setting this if we can't read it?)
- [x] Mark enhacedHue as not support in meta
@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 3, 2021

I opened a PR that marks enhancedHue as unsupported for this device, it should fall back to reading the non enhanced variant. Koenkk/zigbee-herdsman-converters#2445

@shirou93
Copy link
Author

shirou93 commented Apr 3, 2021

All Lidl bulbs? Propably all this bulbs have same firmware

I have only E27 but are too E14 and GU10 versions.

@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 3, 2021

Does the E14 get the same result when reading the attribute manually? If so I’ll update the PR.

I could indeed be all Lidl bulbs, but just making that assumption is risky.

@shirou93
Copy link
Author

shirou93 commented Apr 3, 2021

Does the E14 get the same result when reading the attribute manually? If so I’ll update the PR.

I could indeed be all Lidl bulbs, but just making that assumption is risky.

On Lidl online store this bulbs is one product with another thread. I'm pretty sure this is same supported atributes.

@shirou93
Copy link
Author

shirou93 commented Apr 3, 2021

Screenshot_20210404-002002

@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 3, 2021

@Koenkk are you OK with applying this to all RGB bulbs from Lidl?

Koenkk pushed a commit to Koenkk/zigbee-herdsman-converters that referenced this issue Apr 4, 2021
As discovered in Koenkk/zigbee2mqtt#6921 these bulbs do not support enhancedHue.

- [x] Update the saveClusterAttributeKeyValue (Wy are we even setting this if we can't read it?)
- [x] Mark enhacedHue as not support in meta
@Koenkk
Copy link
Owner

Koenkk commented Apr 4, 2021

@sjorge yes, they probably share the same fw.

sjorge added a commit to sjorge/zigbee-herdsman-converters that referenced this issue Apr 4, 2021
Koenkk pushed a commit to Koenkk/zigbee-herdsman-converters that referenced this issue Apr 4, 2021
@shirou93
Copy link
Author

shirou93 commented Apr 6, 2021

@sjorge thanks for fix. I have one more question. This issue causes change color bulp in home assistant ui on default choised from zigbee2mqtt? When i change different color on HomeAssistant UI after a while in UI HomeAssistant color change to last choised in zigbee2mqtt ui (bulb no change color phisicly). It's wery strange
image

@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 6, 2021

I’m not using homeassisant so I’m not sure what the problem could be.

@shirou93
Copy link
Author

shirou93 commented Apr 6, 2021

@sjorge I tryed only on z2m ui and looks like when change RGB color xy and after change color temp, color rgb xy last state rgb return to ui without change state phisicly in bulb.
image

I'm worried it's the firmware's bulbs fault :( @sjorge can you check this?

Maybe this issue is on all RGB lights. I will check when i get RGB LED controller.

I bought Ledvance bulb https://www.amazon.pl/gp/product/B07MSC34C3/ref=ppx_yo_dt_b_asin_title_o00_s00?ie=UTF8&psc=1 and check this in saturnday.

@shirou93
Copy link
Author

shirou93 commented Apr 9, 2021

@sjorge Ledvance SMART+ CLASSIC MULTICOLOUR 60 10W E27 (AC25697) have same issue
"when change RGB color xy and after change color temp, color rgb xy last state rgb return to ui without change state phisicly in bulb."

@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 9, 2021

Can you read the same attribute like for the lidl one? If it shows the same log entry it’s an easy fix.

Edit: wait your describing a different issue now right? Not the UNSUPPORTED_ATTRIBUTE

@shirou93
Copy link
Author

shirou93 commented Apr 9, 2021

I thought it was related. Ledvance not have issue UNSUPPORTED_ATTRIBUTE.

@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 9, 2021

There are currently a few know issues with color_temp/xy/hs not being in sync when changing one.
There are 2 PR open to address this, one is making some good progress the other is on hold waiting for the other one.

It's a not so trivial issue is a mix of read/report/set and each play a part, and it's not one size fits all unfortunately.

Koenkk/zigbee-herdsman-converters#2453 bigish refactor of the color handling code
Koenkk/zigbee-herdsman-converters#2441 should fix the color/color_temp sync issues (currently waiting on 2453)

@shirou93
Copy link
Author

shirou93 commented Apr 9, 2021

@sjorge thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants