Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Home Assistant select entities all enabled by default #8083

Closed
frenck opened this issue Jul 20, 2021 · 4 comments
Closed

New Home Assistant select entities all enabled by default #8083

frenck opened this issue Jul 20, 2021 · 4 comments
Labels
problem Something isn't working

Comments

@frenck
Copy link
Contributor

frenck commented Jul 20, 2021

What happened

Extracted this comment into this issue: #7980 (comment)

Introduced in #7980, also related to #8078

image

These entities are not really "common". As in, they can be useful, but probably most people won't use them in their automation or dashboards in general. Therefore, it is recommended to send a disabled by default in Home Assistant. This allows a user to enable them when needed, but not overwhelm the user with entities they do not need or pollute the (historical) database unneeded.

Can we adjust this for this feature before release it to the public?

What did you expect to happen

To have less common entities disabled by default, keeping setups nice and tidy.

How to reproduce it (minimal and precise)

Debug info

Zigbee2MQTT version: 1.20.0-dev commit: 46e2a77
Adapter hardware: Conbee II
Adapter firmware version: 0x26660700

@ruifung
Copy link
Contributor

ruifung commented Jul 20, 2021

The same could be said of the previous behavior of a sensor entity used to expose enums though, and that is still used to expose composite exposes.

@frenck
Copy link
Contributor Author

frenck commented Jul 20, 2021

The same could be said of the previous behavior of a sensor entity used to expose enums though

This has been corrected in #7684 and released in 1.20.0.
It will only affect new devices and entities (thus backward compatible, if you have those sensors already, they would not just disappear).

These should be disabled by default, if this PR was on the Home Assistant side, it would not have been accepted in the state it was merged.

@ruifung
Copy link
Contributor

ruifung commented Jul 20, 2021

Well, according to that PR, that behavior is not applied to the enum / text / composite expose types though.

Personally, I'm not entirely sure if the entire category of enum exposes can be classified as to be disabled by default.

In fact, when I authored that PR, I was mostly following existing behavior of those 3 expose types which are epxosed as sensor entities that were enabled by default.

@frenck
Copy link
Contributor Author

frenck commented Jul 20, 2021

In fact, when I authored that PR, I was mostly following existing behavior of those 3 expose types which are epxosed as sensor entities that were enabled by default.

Actually, you are right! 👍
I do have sensors for those already (although all manually disabled at some point in history according to my entity registry data).

Personally, I'm not entirely sure if the entire category of enum exposes can be classified as to be disabled by default.

Maybe just enum isn't specific enough to decide on exposing it with, so instead, we can add them to the lookup table and handle it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants