Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another Fork #1

Closed
wants to merge 26 commits into from
Closed

Another Fork #1

wants to merge 26 commits into from

Conversation

oskarn97
Copy link

@oskarn97 oskarn97 commented Apr 8, 2018

Hey,
we were seeing that you are also working on a fork with features, we also implemented.
If you like have a look at my fork with a different number of other features like a firmware such as an increased device limit from 20 to 48, support for battery status messages, automatic port selection, yaml config, MQTT commands and other cool stuff :)

@Koenkk
Copy link
Owner

Koenkk commented Apr 9, 2018

Thanks for contacting, looks very good!

I'm currently planning to:

  • Refactor the code to make adding new device much more easy.
  • Provide an A-Z guide on which items to buy, how to flash the stick and provide examples on how to integrate with https://www.home-assistant.io/
  • Provide Docker images
  • Support friendly device names

@dgomes
Copy link
Contributor

dgomes commented Apr 9, 2018

Hi @Koenkk!

I'm also integrating with home-assistant.io, I'm running a testing version with MQTT discovery implemented into xiaomi-zb2mqtt.

I've contributed to @oskarn97 repository since at the time I forked he had the most active fork, and since another developer has also contributed.

I'm all in for your current plan and can help out although I'm not a nodejs native programmer (more python here)

@dgomes
Copy link
Contributor

dgomes commented Apr 9, 2018

We should decide wether we merge with @oskarn97 repository or start an organisation and a common repository.

@Koenkk
Copy link
Owner

Koenkk commented Apr 9, 2018

I'm fine with starting an organisation.

However I first want to complete the refactoring step because this has quite an impact on the current code (to avoid merge conflicts).

@djordyg djordyg mentioned this pull request Mar 5, 2021
@aceindy aceindy mentioned this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants