Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cover motor_state in HA #11926

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Handle cover motor_state in HA #11926

merged 3 commits into from
Mar 23, 2022

Conversation

Drafteed
Copy link
Contributor

This is a logical improvement of #11789. Now we can get the actual curtain state and movement direction based on the motor_state, as opposed to the running state where the direction is guessed.

Video demo
2022-03-22_21-27-25.mp4
2022-03-22_21-20-19.mp4

@Drafteed Drafteed changed the title Handle cover motor_state in HA Handle cover motor_state in HA Mar 22, 2022
@Koenkk
Copy link
Owner

Koenkk commented Mar 22, 2022

Looks fine to me, could you fix the linting issues by running npm run eslint locally?

@Drafteed
Copy link
Contributor Author

@Koenkk done 👌

@Koenkk
Copy link
Owner

Koenkk commented Mar 23, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants